Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: typo in CreateCertificateRequest docs #8936

Closed
gopherbot opened this issue Oct 15, 2014 · 2 comments
Closed

crypto/x509: typo in CreateCertificateRequest docs #8936

gopherbot opened this issue Oct 15, 2014 · 2 comments
Labels
FrozenDueToAge

Comments

@gopherbot
Copy link

by carl@stripe.com:

The docs at http://golang.org/pkg/crypto/x509/#CreateCertificateRequest read:

"""
CreateCertificateRequest creates a new certificate based on a template. The following
members of template are used: Subject, Attributes, SignatureAlgorithm, Extension,
DNSNames, EmailAddresses, and IPAddresses. The private key is the private key of the
signer.
"""

The field on CertificateRequest is named "Extensions," not
"Extension"
@gopherbot
Copy link
Author

Comment 1:

CL https://golang.org/cl/152590043 mentions this issue.

@ianlancetaylor
Copy link
Contributor

Comment 2:

This issue was closed by revision a681749.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@ianlancetaylor @wheatman
crypto/x509: correct field name in comment
c93a7fc 
Fixes golang#8936.

LGTM=bradfitz
R=agl, bradfitz
CC=golang-codereviews
https://golang.org/cl/152590043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
@ianlancetaylor @wheatman
crypto/x509: correct field name in comment
28a7293 
Fixes golang#8936.

LGTM=bradfitz
R=agl, bradfitz
CC=golang-codereviews
https://golang.org/cl/152590043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@ianlancetaylor @wheatman
crypto/x509: correct field name in comment
6d29503 
Fixes golang#8936.

LGTM=bradfitz
R=agl, bradfitz
CC=golang-codereviews
https://golang.org/cl/152590043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@ianlancetaylor @wheatman
crypto/x509: correct field name in comment
a590475 
Fixes golang#8936.

LGTM=bradfitz
R=agl, bradfitz
CC=golang-codereviews
https://golang.org/cl/152590043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianlancetaylor @gopherbot