-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: invalid heap pointer on Windows #8911
Labels
Milestone
Comments
It looks to me like the runtime only uses uintptr for handles now, which is the right fix. If you know of any pointer-typed handles, please send a CL changing them to uintptr. I will add a GODEBUG=invalidptr=0 setting to disable to check as a temporary workaround for people, but the right fix is to fix the code. The workaround may not be enough in future releases. Status changed to Accepted. |
CL https://golang.org/cl/165780043 mentions this issue. |
Status changed to Duplicate. Merged into issue #8961. |
Sorry for confusion. This is fixed by revision 98477b56eb36, not by https://golang.org/cl/165780043. It, probably, is fixed. Lets leave it closed. Unless we see it again. I could not reproduce it here anyway. Alex |
This issue was closed by revision 8fcdc70. Status changed to Fixed. |
I also thought this was one of the 'handle isn't really a pointer' bugs, hence the comment in #5 and the intended merging into the 'disable invalid ptr checks' bug. I don't quite see how the CL that fixed 8911 (camlistore init) could fix this problem. If it's not a windows handle, then it's probably flakiness that we need to track down. Status changed to Accepted. |
Status changed to Duplicate. Merged into issue #9015. |
This was referenced Dec 8, 2014
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
Fixes golang#8861. Fixes golang#8911. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/165780043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 26, 2018
Fixes golang#8861. Fixes golang#8911. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/165780043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
Fixes golang#8861. Fixes golang#8911. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/165780043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 20, 2018
Fixes golang#8861. Fixes golang#8911. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/165780043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 30, 2018
Fixes golang#8861. Fixes golang#8911. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/165780043
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: