Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: memory profiling is broken #8867

Closed
dvyukov opened this issue Oct 4, 2014 · 5 comments
Closed

runtime: memory profiling is broken #8867

dvyukov opened this issue Oct 4, 2014 · 5 comments
Milestone

Comments

@dvyukov
Copy link
Member

dvyukov commented Oct 4, 2014

Memory profiling is broken on tip. Nobody knows.

Compare go1.3:
http://build.golang.org/log/544cc70c89d2c5e01e3785640ecf822f5bc9df3e
with tip:
http://build.golang.org/log/1ec930e36e1ccb3c480357787e67d0002f29bab6

Now everything is allocated in profilealloc:
423624704 100.0% 100.0% 423624704 100.0% runtime.profilealloc
/usr/local/go/src/runtime/malloc.go:409

Need tests.
@rsc
Copy link
Contributor

rsc commented Oct 7, 2014

Comment 1:

Dmitriy, can you look at this?

Status changed to Accepted.

@gopherbot
Copy link

Comment 2:

CL https://golang.org/cl/148710043 mentions this issue.

@dvyukov
Copy link
Member Author

dvyukov commented Oct 16, 2014

Comment 3:

This issue was closed by revision 8f47c83.

Status changed to Fixed.

@rsc
Copy link
Contributor

rsc commented Oct 16, 2014

Comment 4:

This issue was updated by revision 25f79b9.

TBR=dvyukov
CC=golang-codereviews
https://golang.org/cl/153710043

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Nov 19, 2014

Comment 5:

memory profiling is working well enough that it isolated the sudog leak. 
Without more details about what "is broken" means, closing.

Status changed to Fixed.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
There are 3 issues:
1. Skip argument of callers is off by 3,
so that all allocations are deep inside of memory profiler.
2. Memory profiling statistics are not updated after runtime.GC.
3. Testing package does not update memory profiling statistics
before capturing the profile.
Also add an end-to-end test.
Fixes golang#8867.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/148710043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
There are 3 issues:
1. Skip argument of callers is off by 3,
so that all allocations are deep inside of memory profiler.
2. Memory profiling statistics are not updated after runtime.GC.
3. Testing package does not update memory profiling statistics
before capturing the profile.
Also add an end-to-end test.
Fixes golang#8867.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/148710043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
There are 3 issues:
1. Skip argument of callers is off by 3,
so that all allocations are deep inside of memory profiler.
2. Memory profiling statistics are not updated after runtime.GC.
3. Testing package does not update memory profiling statistics
before capturing the profile.
Also add an end-to-end test.
Fixes golang#8867.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/148710043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
There are 3 issues:
1. Skip argument of callers is off by 3,
so that all allocations are deep inside of memory profiler.
2. Memory profiling statistics are not updated after runtime.GC.
3. Testing package does not update memory profiling statistics
before capturing the profile.
Also add an end-to-end test.
Fixes golang#8867.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/148710043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants