Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tour: keyboard shortcut not working (new ui) #8829

Closed
dupoxy opened this issue Sep 28, 2014 · 1 comment
Closed

x/tour: keyboard shortcut not working (new ui) #8829

dupoxy opened this issue Sep 28, 2014 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@dupoxy
Copy link
Contributor

dupoxy commented Sep 28, 2014 

on the new go-tour ui keyboard shortcut are
not working at all in Firefox 32.0.3 (OS linux: ubuntu )

What steps reproduce the problem?

1. open http://2.go-tour-fr.appspot.com or http://go-tour-zh.appspot.com in firefox
32.0.3
2. press PageDown or any other defined key shortcut

What happened?

Nothing.

What should have happened instead?

Go to next step.

some notes:
the new ui works as expected on chrome 36
the old ui works as expected on firefox 32.0.3
tested with go-tour Revision: 90b120f7b8fc (on http://2.go-tour-fr.appspot.com)

P.S: should go-tour issue be reported like that or on the go-tour issue page. I see that
both are used, maybe add a note about it somewhere to clarify.
@griesemer
Copy link
Contributor

Comment 1:

Labels changed: added repo-tour.

@dupoxy dupoxy added new labels Oct 1, 2014
@bradfitz bradfitz removed the new label Dec 18, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title go-tour: keyboard shortcut not working (new ui) x/tour: keyboard shortcut not working (new ui) Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-tour label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Sep 27, 2016
gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
@andrewaustin @adg
[x/tour] tour: fix pageup/pagedown navigation on non-chrome browsers
a00061e 
FF and IE fail to populate event.keyCode, but instead populate
event.which with the key code. event.key is a DOMString of "PageUp"
or "PageDown" in this case, so remove the invalid comparision to a
numeric key code and instead compare the keycode to event.which.

Fixes golang/go#8829

Change-Id: I7192d2e561e2be5472018d8a3b06a91ab9dab49b
Reviewed-on: https://go-review.googlesource.com/15001
Reviewed-by: Andrew Gerrand <adg@golang.org>
X-Tour-Commit: aef6c802ede697bfc71a740ccd720cc12c6de29b
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
[x/tour] tour: fix pageup/pagedown navigation on non-chrome browsers
f133cb3 
FF and IE fail to populate event.keyCode, but instead populate
event.which with the key code. event.key is a DOMString of "PageUp"
or "PageDown" in this case, so remove the invalid comparision to a
numeric key code and instead compare the keycode to event.which.

Fixes golang/go#8829

Change-Id: I7192d2e561e2be5472018d8a3b06a91ab9dab49b
Reviewed-on: https://go-review.googlesource.com/15001
Reviewed-by: Andrew Gerrand <adg@golang.org>
X-Tour-Commit: aef6c802ede697bfc71a740ccd720cc12c6de29b
KimuraDanaka119 added a commit to KimuraDanaka119/go-tour-jp that referenced this issue Jun 4, 2023
@KimuraDanaka119
tour: fix pageup/pagedown navigation on non-chrome browsers
79290f2 
FF and IE fail to populate event.keyCode, but instead populate
event.which with the key code. event.key is a DOMString of "PageUp"
or "PageDown" in this case, so remove the invalid comparision to a
numeric key code and instead compare the keycode to event.which.

Fixes golang/go#8829

Change-Id: I7192d2e561e2be5472018d8a3b06a91ab9dab49b
Reviewed-on: https://go-review.googlesource.com/15001
Reviewed-by: Andrew Gerrand <adg@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@bradfitz @rsc @dupoxy @griesemer @gopherbot