Skip to content

x/net/context: flaky test TestAllocs #8709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ribrdb opened this issue Sep 11, 2014 · 4 comments
Closed

x/net/context: flaky test TestAllocs #8709

ribrdb opened this issue Sep 11, 2014 · 4 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@ribrdb
Copy link
Contributor

ribrdb commented Sep 11, 2014 

The context.TestAllocs test is flaky on our jenkins continuous build. It seems to fail
more often when the machine is heavily loaded.


=== RUN TestAllocs
--- FAIL: TestAllocs (0.11 seconds)
    context_test.go:349: WithTimeout(bg, 1*time.Nanosecond) allocs = 8.000000 want 7
@ianlancetaylor
Copy link
Member

Comment 1:

Labels changed: added repo-net, release-go1.4.

@rsc
Copy link
Contributor

rsc commented Sep 15, 2014

Comment 3:

Labels changed: added release-none, removed release-go1.4.

@Sajmani
Copy link
Contributor

Sajmani commented Sep 18, 2014

Comment 4:

Was this fixed by 8734?

Owner changed to @Sajmani.

@bradfitz bradfitz removed the new label Dec 18, 2014
@mikioh mikioh changed the title go.net/context: flaky test code.google.com/p/go.net/context.TestAllocs x/net/context: flaky test code.google.com/p/go.net/context.TestAllocs Dec 23, 2014
@mikioh mikioh changed the title x/net/context: flaky test code.google.com/p/go.net/context.TestAllocs x/net/context: flaky test TestAllocs Dec 23, 2014
@mikioh mikioh added repo-net and removed repo-net labels Dec 23, 2014
@mikioh mikioh changed the title x/net/context: flaky test TestAllocs context: flaky test TestAllocs Jan 4, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc removed the release-none label Apr 10, 2015
@rsc rsc changed the title context: flaky test TestAllocs x/net/context: flaky test TestAllocs Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-net label Apr 14, 2015
@Sajmani
Copy link
Contributor

Sajmani commented Aug 14, 2015

ribrdb: is this still an issue? Since this report, there have been changes to TestAllocs to use a longer timeout and changes to AllocsPerRun in the testing package. Since I don't have a way to reproduce this, I cannot easily determine whether those changes have resolved this. Please reopen if so, ideally with reproduction steps.

@Sajmani Sajmani closed this as completed Aug 14, 2015
@golang golang locked and limited conversation to collaborators Aug 22, 2016
@rsc rsc unassigned Sajmani Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
7 participants
@bradfitz @ribrdb @mikioh @rsc @ianlancetaylor @gopherbot @Sajmani