-
Notifications
You must be signed in to change notification settings - Fork 18k
runtime: gostringnocopy doesn't update maxstring #8706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
I think we should fix this. The cost isn't that much, only a load/compare/branch in the common case. It's a lot less than the findnull the code has to do. Owner changed to @randall77. |
CL https://golang.org/cl/143880043 mentions this issue. |
This issue was closed by revision bcd36e8. Status changed to Fixed. |
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
Fixes golang#8706 LGTM=josharian R=josharian CC=golang-codereviews https://golang.org/cl/143880043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
Fixes golang#8706 LGTM=josharian R=josharian CC=golang-codereviews https://golang.org/cl/143880043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 30, 2018
Fixes golang#8706 LGTM=josharian R=josharian CC=golang-codereviews https://golang.org/cl/143880043
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: