Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: SetKeepAlivePeriod behaves differently from other platfroms on OS X 10.8 and beyond #8701

Closed
mikioh opened this issue Sep 11, 2014 · 2 comments
Closed

net: SetKeepAlivePeriod behaves differently from other platfroms on OS X 10.8 and beyond #8701

mikioh opened this issue Sep 11, 2014 · 2 comments
Labels
FrozenDueToAge

Comments

@mikioh
Copy link
Contributor

mikioh commented Sep 11, 2014 

The behavior is different from other platforms because it doesn't use TCP_KEEPINTVL when
possible.
@gopherbot
Copy link

Comment 1:

CL https://golang.org/cl/136480043 mentions this issue.

@mikioh
Copy link
Contributor Author

mikioh commented Sep 11, 2014

Comment 2:

This issue was closed by revision f956740.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@cixtor @wheatman
net: fix inconsistent behavior across platforms in SetKeepAlivePeriod
086fc87 
The previous implementation used per-socket TCP keepalive options
wrong. For example, it used another level socket option to control
TCP and it didn't use TCP_KEEPINTVL option when possible.

Fixes golang#8683.
Fixes golang#8701.
Update golang#8679

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/136480043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@cixtor @wheatman
net: fix inconsistent behavior across platforms in SetKeepAlivePeriod
978d8aa 
The previous implementation used per-socket TCP keepalive options
wrong. For example, it used another level socket option to control
TCP and it didn't use TCP_KEEPINTVL option when possible.

Fixes golang#8683.
Fixes golang#8701.
Update golang#8679

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/136480043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@cixtor @wheatman
net: fix inconsistent behavior across platforms in SetKeepAlivePeriod
3998e10 
The previous implementation used per-socket TCP keepalive options
wrong. For example, it used another level socket option to control
TCP and it didn't use TCP_KEEPINTVL option when possible.

Fixes golang#8683.
Fixes golang#8701.
Update golang#8679

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/136480043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikioh @gopherbot