Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm: error on overlap #8700

Closed
randall77 opened this issue Sep 11, 2014 · 4 comments
Closed

cmd/asm: error on overlap #8700

randall77 opened this issue Sep 11, 2014 · 4 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Unplanned

Comments

@randall77
Copy link
Contributor 

It would be nice if the assemblers generated an error for data statements that
overlapped:

DATA foo+0x00(SB)/4, $7
DATA foo+0x04(SB)/4, $8
DATA foo+0x04(SB)/4, $9

The last two statements are in conflict - the user probably wanted to have 0x08 in the
last line.
@bradfitz
Copy link
Contributor

Comment 1:

Status changed to Accepted.

@robpike
Copy link
Contributor

robpike commented Oct 1, 2014

Comment 3:

Surprised this isn't caught by liblink.

@randall77 randall77 added accepted Suggested Issues that may be good for new contributors looking for work to do. labels Oct 1, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@josharian josharian changed the title cmd/{5,6,8}a: error on overlap cmd/asm: error on overlap Feb 13, 2018
@agnivade
Copy link
Contributor

@randall77 - This fails now with the error -

math/exp_amd64.s:31: overlapping DATA entry for exprodata
asm: assembly of math/exp_amd64.s failed

I did - go tool asm -I runtime/ math/exp_amd64.s

Kindly check and close if this looks fixed to you.

@randall77
Copy link
Contributor Author

Yes, looks fixed.

@golang golang locked and limited conversation to collaborators Jun 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
6 participants
@bradfitz @rsc @agnivade @robpike @randall77 @gopherbot