Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: Stack returns the empty string #8626

Closed
bradfitz opened this issue Sep 1, 2014 · 3 comments
Closed

runtime: Stack returns the empty string #8626

bradfitz opened this issue Sep 1, 2014 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Sep 1, 2014 

runtime.Stack is broken. It returns 0 from Stack(buf, false) and doesn't write any data
to the buffer either.

Mathieu reports it was broken by
https://code.google.com/p/go/source/detail?r=2dae02db5c70c3402ce8c09c26474acce41be29a
and caught by Camlistore's buildbot (which has a builder testing against Go tip)
@gopherbot
Copy link
Contributor

Comment 1:

CL https://golang.org/cl/134260043 mentions this issue.

@gopherbot
Copy link
Contributor

Comment 2:

CL https://golang.org/cl/137050043 mentions this issue.

@rsc
Copy link
Contributor

rsc commented Sep 1, 2014

Comment 3:

This issue was closed by revision a8c5e87.

Status changed to Fixed.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@rsc @wheatman
runtime: fix Stack
5ce18f6 
Fixes golang#8626.

LGTM=bradfitz
R=golang-codereviews
CC=bradfitz, golang-codereviews, iant, r
https://golang.org/cl/137050043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@rsc @wheatman
runtime: fix Stack
134e9b0 
Fixes golang#8626.

LGTM=bradfitz
R=golang-codereviews
CC=bradfitz, golang-codereviews, iant, r
https://golang.org/cl/137050043
@rsc rsc removed their assignment Jun 23, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
3 participants
@bradfitz @rsc @gopherbot