Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: builtin dns stub resolver doesn't accept ipv6 link-local address w/ zone identifier notation #8619

Closed
mikioh opened this issue Aug 30, 2014 · 3 comments
Closed

net: builtin dns stub resolver doesn't accept ipv6 link-local address w/ zone identifier notation #8619

mikioh opened this issue Aug 30, 2014 · 3 comments
Labels
FrozenDueToAge

Comments

@mikioh
Copy link
Contributor

mikioh commented Aug 30, 2014 

for example,

nameserver fe80::1%tengige-0
@mikioh
Copy link
Contributor Author

mikioh commented Sep 3, 2014

Comment 1:

dnsReadConfig uses ParseIP for parsing nameserver entries but ParseIP can only parse a
literal IP address without zone identifier. To fix this issue we should use either a
combo of parseIPv4+parseIPv6 or ResolveIPAddr.

@gopherbot
Copy link

Comment 2:

CL https://golang.org/cl/132560043 mentions this issue.

@mikioh
Copy link
Contributor Author

mikioh commented Sep 4, 2014

Comment 3:

This issue was closed by revision f403416.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@cixtor @wheatman
net: fix parsing literal IPv6 address with zone identifier in builtin…
bab4ce9 
… dns stub resolver

Fixes golang#8619.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/132560043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@cixtor @wheatman
net: fix parsing literal IPv6 address with zone identifier in builtin…
b81e83e 
… dns stub resolver

Fixes golang#8619.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/132560043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikioh @gopherbot