Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: document Server recovering panics #8594

Closed
bradfitz opened this issue Aug 26, 2014 · 4 comments
Closed

net/http: document Server recovering panics #8594

bradfitz opened this issue Aug 26, 2014 · 4 comments

Comments

@bradfitz
Copy link
Contributor

The net/http don't mention anything about the Server's behavior recovering from Handler
panics.
@Grovespaz
Copy link

Comment 1:

I've been looking at this and I can't decide where this should be mentioned.
type Handler?
func Handle & HandleFunc?
func ListenAndServe & Server.ListenAndServe?
func Server.Serve?
The actual recovering happens in conn.serve, so to the user the closest thing is
Server.Serve. However, I expect most users won't look at that but at ListenAndServe or
Handle and HandleFunc.

@Grovespaz
Copy link

Comment 2:

I've been looking at this and I can't decide where this should be mentioned.
type Handler?
func Handle & HandleFunc?
func ListenAndServe & Server.ListenAndServe?
func Server.Serve?
The actual recovering happens in conn.serve, so to the user the closest thing is
Server.Serve. However, I expect most users won't look at that but at ListenAndServe or
Handle and HandleFunc.

@gopherbot
Copy link

Comment 3:

CL https://golang.org/cl/145760043 mentions this issue.

@rsc
Copy link
Contributor

rsc commented Sep 19, 2014

Comment 4:

This issue was closed by revision 2c15d45.

Status changed to Fixed.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants