New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: document Server recovering panics #8594
Labels
Milestone
Comments
I've been looking at this and I can't decide where this should be mentioned. type Handler? func Handle & HandleFunc? func ListenAndServe & Server.ListenAndServe? func Server.Serve? The actual recovering happens in conn.serve, so to the user the closest thing is Server.Serve. However, I expect most users won't look at that but at ListenAndServe or Handle and HandleFunc. |
I've been looking at this and I can't decide where this should be mentioned. type Handler? func Handle & HandleFunc? func ListenAndServe & Server.ListenAndServe? func Server.Serve? The actual recovering happens in conn.serve, so to the user the closest thing is Server.Serve. However, I expect most users won't look at that but at ListenAndServe or Handle and HandleFunc. |
CL https://golang.org/cl/145760043 mentions this issue. |
This issue was closed by revision 2c15d45. Status changed to Fixed. |
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
Fixes golang#8594. LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/145760043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
Fixes golang#8594. LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/145760043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 30, 2018
Fixes golang#8594. LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/145760043
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: