Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: panic from Go on new C thread crashes silently #8588

Closed
niemeyer opened this issue Aug 25, 2014 · 5 comments
Closed

runtime: panic from Go on new C thread crashes silently #8588

niemeyer opened this issue Aug 25, 2014 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@niemeyer
Copy link
Contributor 

What steps will reproduce the problem?

1. Call a C function that creates a thread
2. Callback into Go from the new thread
3. panic from the Go

What is the expected output? What do you see instead?

Expected a panic message and a traceback, but does a silent SIGSEGV instead.

In 1.2.2, there was at least a proper traceback leading to the SIGSEGV. In 1.3.1, it's
just completely silent, even if GOTRACEBACK=2 is set.

Attaching the reproducer and its output on 1.2.2 and 1.3.1.

Attachments:

  1. crash.go (161 bytes)
  2. crash.c (257 bytes)
  3. go1.2.2.output (2190 bytes)
  4. go1.3.1.output (33 bytes)
@ianlancetaylor
Copy link
Member

Comment 1:

Labels changed: added repo-main, release-go1.4.

@rsc
Copy link
Contributor

rsc commented Sep 18, 2014

Comment 2:

This doesn't die silently anymore but it still doesn't manage to report the right panic.
On OS X I get an unexpected fault in the runtime and on Linux I get a SIGTRAP.

Status changed to Accepted.

@gopherbot
Copy link
Contributor

Comment 3:

CL https://golang.org/cl/159700044 mentions this issue.

@rsc
Copy link
Contributor

rsc commented Oct 29, 2014

Comment 4:

This issue was closed by revision c4efaac.

Status changed to Fixed.

@niemeyer
Copy link
Contributor Author

Comment 5:

Thanks!

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@rsc @wheatman
runtime: fix unrecovered panic on external thread
a6640ab 
Fixes golang#8588.

LGTM=austin
R=austin
CC=golang-codereviews, khr
https://golang.org/cl/159700044
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
@rsc @wheatman
runtime: fix unrecovered panic on external thread
8ccacaf 
Fixes golang#8588.

LGTM=austin
R=austin
CC=golang-codereviews, khr
https://golang.org/cl/159700044
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@rsc @wheatman
runtime: fix unrecovered panic on external thread
7a685ce 
Fixes golang#8588.

LGTM=austin
R=austin
CC=golang-codereviews, khr
https://golang.org/cl/159700044
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 20, 2018
@rsc @wheatman
runtime: fix unrecovered panic on external thread
9fa231f 
Fixes golang#8588.

LGTM=austin
R=austin
CC=golang-codereviews, khr
https://golang.org/cl/159700044
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@rsc @wheatman
runtime: fix unrecovered panic on external thread
adc804f 
Fixes golang#8588.

LGTM=austin
R=austin
CC=golang-codereviews, khr
https://golang.org/cl/159700044
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
4 participants
@rsc @niemeyer @ianlancetaylor @gopherbot