runtime: TestSetPanicOnFault fails sometimes #8542
Labels
Milestone
Comments
I think when running 32-bit programs with a 64-bit kernel, all first 4GB of address space is usable by the program, so we probably should remove all entries in faultAddrs that have maps to 0xf0000000~0xffff0000 in 32-bit systems. Or we need to find a way to detect 64-bit kernels and only enable those test caes when actually running on 32-bit kernels. |
CL https://golang.org/cl/144120043 mentions this issue. |
|
This issue was closed by revision 5fdea34. Status changed to Fixed. |
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
We can't assume all those addresses are unmapped. But at least one should be. What we're really testing is that the program doesn't crash. Fixes golang#8542. LGTM=iant R=golang-codereviews, iant, minux CC=golang-codereviews https://golang.org/cl/144120043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
We can't assume all those addresses are unmapped. But at least one should be. What we're really testing is that the program doesn't crash. Fixes golang#8542. LGTM=iant R=golang-codereviews, iant, minux CC=golang-codereviews https://golang.org/cl/144120043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 30, 2018
We can't assume all those addresses are unmapped. But at least one should be. What we're really testing is that the program doesn't crash. Fixes golang#8542. LGTM=iant R=golang-codereviews, iant, minux CC=golang-codereviews https://golang.org/cl/144120043
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by cdunn2001:
What does 'go version' print? go version go1.3 linux/amd64 But that's a 64-bit virtual machine, where it passes. It fails *sometimes* (with the exact same code-base) on a 32-bit virt, which I cannot easily access. What steps reproduce the problem? A test fails while building compiler. What happened? … ok regexp/syntax 0.809s 0 --- FAIL: TestSetPanicOnFault (0.00 seconds) runtime_test.go:203: still here - should have faulted on address 0xff000001 runtime_test.go:196: did not find error in recover FAIL FAIL runtime 13.519s [no test files] ? runtime/cgo ok runtime/debug 0.012s … What should have happened instead? ok runtime 14s Please provide any additional information below. RHEL5 (32-bit) Definitely go-1.3 I think it's a many-processor machine, but it shares memory with other jobs. That makes me think it might be related to #7554. It does not seem to be related to #7421.The text was updated successfully, but these errors were encountered: