net/http: ResponseWriter leaves connection open after WriteTimeout #8534
Labels
Milestone
Comments
Seems to be related to keepalive. An HTTP1.1 connection hangs, but an HTTP1.0 connection is closed imediately. If you do run the first server code I posted with both timeouts, the client takes 3s to return because the connection is left in keepalive, and the ReadTimeout is what shuts it down. |
|
Owner changed to @bradfitz. |
Found it. There are dozens of writes that don't check the error return value. It's almost always fine because they're buffered, but you never know where a buffer boundary will be. Some Flushes weren't checking either. Note to self: the easiest fix is something like https://golang.org/cl/149340044 which catches them all. Needs tests. Status changed to Started. |
|
Issue #8648 has been merged into this issue. |
CL https://golang.org/cl/149340044 mentions this issue. |
|
This issue was closed by revision 9d51cd0. Status changed to Fixed. |
|
Issue #8648 has been merged into this issue. |
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
Fixes golang#8534 LGTM=adg R=adg CC=golang-codereviews https://golang.org/cl/149340044
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 26, 2018
Fixes golang#8534 LGTM=adg R=adg CC=golang-codereviews https://golang.org/cl/149340044
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
Fixes golang#8534 LGTM=adg R=adg CC=golang-codereviews https://golang.org/cl/149340044
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 30, 2018
Fixes golang#8534 LGTM=adg R=adg CC=golang-codereviews https://golang.org/cl/149340044
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
go1.3.1 run the following http server: ``` package main import ( "fmt" "net/http" "time" ) func handler(w http.ResponseWriter, r *http.Request) { time.Sleep(2 * time.Second) msg := []byte("Hello world!\n") n, err := w.Write(msg) fmt.Printf("Wrote %d out of %d bytes\n", n, len(msg)) fmt.Println("Error was:", err) } func main() { http.HandleFunc("/", handler) server := http.Server{ Addr: ":8123", ReadTimeout: time.Second, WriteTimeout: time.Second, } server.ListenAndServe() } ``` What happens: The Write always succeeds in this handler, and the connection is left open hanging the client. What should happen: - Connection closed due to timeout - Preferably return an error when writes fail (though this may not be feasible due to internal buffering)The text was updated successfully, but these errors were encountered: