New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/dist: goc2c ignores GOROOT_FINAL #8524
Labels
Milestone
Comments
Can you send the patch using the process described at http://golang.org/doc/contribute.html ? Thanks. Status changed to Accepted. |
Comment 3 by henning@schmiedehausen.org: Done. See https://golang.org/cl/128230046 |
CL https://golang.org/cl/128230046 mentions this issue. |
This issue was closed by revision 7eba885. Status changed to Fixed. |
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
When building golang, the environment variable GOROOT_FINAL can be set to indicate a different installation location from the build location. This works fine, except that the goc2c build step embeds line numbers in the resulting c source files that refer to the build location, no the install location. This would not be a big deal, except that in turn the linker uses the location of runtime/string.goc to embed the gdb script in the resulting binary and as a net result, the debugger now complains that the script is outside its load path (it has the install location configured). See https://code.google.com/p/go/issues/detail?id=8524 for the full description. Fixes golang#8524. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/128230046
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
When building golang, the environment variable GOROOT_FINAL can be set to indicate a different installation location from the build location. This works fine, except that the goc2c build step embeds line numbers in the resulting c source files that refer to the build location, no the install location. This would not be a big deal, except that in turn the linker uses the location of runtime/string.goc to embed the gdb script in the resulting binary and as a net result, the debugger now complains that the script is outside its load path (it has the install location configured). See https://code.google.com/p/go/issues/detail?id=8524 for the full description. Fixes golang#8524. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/128230046
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by henning@schmiedehausen.org:
Attachments:
The text was updated successfully, but these errors were encountered: