-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/vet: go vet syscall doesn't show anything whereas go tool vet pkg/syscall shows a warning #8511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
The issue seems to be creds_test.go (which is a "+build linux" file) is in package syscall_test. I think it being first in the list causes vet to skip over the remaining files that are in package syscall. If I move creds_test.go into a different directory, then running "go vet syscall" shows me the sockcmsg_unix.go unsafe.Pointer warning. That would also explain why Russ and Rob are seeing different behavior on darwin. |
CL https://golang.org/cl/125990044 mentions this issue. |
Is this important enough to be fixed for Go 1.4? I think it's worth noting that the issue isn't specific to package syscall: it affects any package where the first XTestGoFiles comes alphabetically before all GoFiles, CgoFiles, and TestGoFiles. Within the standard library, the full list of affected packages (at least for GOOS=linux GOARCH=amd64) is: archive/zip compress/zlib container/heap container/list crypto/cipher crypto/md5 crypto/rand crypto/sha1 flag go/printer image log math/rand mime/multipart net/http/httptest net/url os/exec os/signal path path/filepath reflect sort strings sync/atomic syscall text/tabwriter time unicode/utf8 |
Owner changed to @rsc. |
CL https://golang.org/cl/152220044 mentions this issue. |
This issue was closed by revision 7e6e502. Status changed to Fixed. |
Issue #6389 has been merged into this issue. |
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
For example, fixes 'go vet syscall', which has source files in package syscall_test. Fixes golang#8511. LGTM=r R=golang-codereviews, r CC=golang-codereviews, iant https://golang.org/cl/152220044
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 26, 2018
For example, fixes 'go vet syscall', which has source files in package syscall_test. Fixes golang#8511. LGTM=r R=golang-codereviews, r CC=golang-codereviews, iant https://golang.org/cl/152220044
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
For example, fixes 'go vet syscall', which has source files in package syscall_test. Fixes golang#8511. LGTM=r R=golang-codereviews, r CC=golang-codereviews, iant https://golang.org/cl/152220044
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 30, 2018
For example, fixes 'go vet syscall', which has source files in package syscall_test. Fixes golang#8511. LGTM=r R=golang-codereviews, r CC=golang-codereviews, iant https://golang.org/cl/152220044
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: