Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path: Dir function contains dead code. #8503

Closed
nsf opened this issue Aug 10, 2014 · 2 comments
Closed

path: Dir function contains dead code. #8503

nsf opened this issue Aug 10, 2014 · 2 comments

Comments

@nsf
Copy link

nsf commented Aug 10, 2014

http://golang.org/src/pkg/path/path.go?s=5359:5387#L197

Dir function runs Clean(dir) after doing a Split, and after that: it tries to remove a
trailing slash and convert an empty path to ".", none of that code ever runs,
because Clean(dir) takes care about both things.

Not sure if it's worth fixing or not. Similar issues can be observed in the filepath
package.
@gopherbot
Copy link

Comment 1:

CL https://golang.org/cl/132730043 mentions this issue.

@davecheney
Copy link
Contributor

Comment 2:

This issue was closed by revision 3d3d539.

Status changed to Fixed.

@nsf nsf added the fixed label Aug 22, 2014
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
Fixes golang#8503.

Thanks to no.smile.face for the original report.

LGTM=bradfitz, r, ruiu
R=bradfitz, ruiu, r
CC=golang-codereviews
https://golang.org/cl/132730043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
Fixes golang#8503.

Thanks to no.smile.face for the original report.

LGTM=bradfitz, r, ruiu
R=bradfitz, ruiu, r
CC=golang-codereviews
https://golang.org/cl/132730043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants