New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/link: tests fail after regenerating testdata on linux_amd64 #8494
Labels
Comments
Tangentially, http://golang.org/s/go12symtab claims that "nfuncdata" precedes "npcdata", but cmd/ld and cmd/link put "npcdata" first. |
CL https://golang.org/cl/123040043 mentions this issue. |
FWIW, the pclntab_test.go bug was triggered by revision 96917e010ddf9fb400e9e834813a9d3930ae252e. cmd/link/testdata/pclntab.s does not define a PCDATA 0 table, but because of the liblink bug fixed in that CL, 6a previously still emitted a PCDATA table for index 0 that explicitly mapped the entire PC range to -1. With new liblink, 6a emits a "0" value in index 0, which pclntab_test.go was erroneously treating as an offset still. That resulted in trying to parse the symtab header (e.g., 0xfffffffb, in LE encoding) as a varint, which seems to then coincide with the unwanted -134217728 value from the error message. |
This issue was closed by revision 2a679f8. Status changed to Fixed. |
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
Fixes golang#8494. LGTM=rsc R=golang-codereviews, gobot, rsc, evankroske CC=golang-codereviews https://golang.org/cl/123040043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
Fixes golang#8494. LGTM=rsc R=golang-codereviews, gobot, rsc, evankroske CC=golang-codereviews https://golang.org/cl/123040043
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: