Skip to content

runtime: implement markallocated in Go #8452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
randall77 opened this issue Jul 30, 2014 · 3 comments
Closed

runtime: implement markallocated in Go #8452

randall77 opened this issue Jul 30, 2014 · 3 comments
Labels
FrozenDueToAge

Comments

@randall77
Copy link
Contributor 

Now that malloc is in Go, we should move markallocated & callees there also. 
Currently we call it by switching to the M stack, running it in C, and switching back.

Dmitry, let me know if you want to tackle this.  If not, I'll get to it at some point.
@dvyukov
Copy link
Member

dvyukov commented Jul 31, 2014

Comment 1:

I will take a look next week.

Status changed to Started.

@gopherbot
Copy link
Contributor

Comment 2:

CL https://golang.org/cl/122090043 mentions this issue.

@dvyukov
Copy link
Member

dvyukov commented Aug 7, 2014

Comment 3:

This issue was closed by revision aac7f1a.

Status changed to Fixed.

@randall77 randall77 added the fixed label Aug 7, 2014
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@dvyukov @wheatman
runtime: convert markallocated from C to Go
1c785ff 
benchmark                      old ns/op     new ns/op     delta
BenchmarkMalloc8               28.7          22.4          -21.95%
BenchmarkMalloc16              44.8          33.8          -24.55%
BenchmarkMallocTypeInfo8       49.0          32.9          -32.86%
BenchmarkMallocTypeInfo16      46.7          35.8          -23.34%
BenchmarkMallocLargeStruct     907           901           -0.66%
BenchmarkGobDecode             13235542      12036851      -9.06%
BenchmarkGobEncode             10639699      9539155       -10.34%
BenchmarkJSONEncode            25193036      21898922      -13.08%
BenchmarkJSONDecode            96104044      89464904      -6.91%

Fixes golang#8452.

LGTM=khr
R=golang-codereviews, bradfitz, rsc, dave, khr
CC=golang-codereviews
https://golang.org/cl/122090043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@dvyukov @wheatman
runtime: convert markallocated from C to Go
a6ff59c 
benchmark                      old ns/op     new ns/op     delta
BenchmarkMalloc8               28.7          22.4          -21.95%
BenchmarkMalloc16              44.8          33.8          -24.55%
BenchmarkMallocTypeInfo8       49.0          32.9          -32.86%
BenchmarkMallocTypeInfo16      46.7          35.8          -23.34%
BenchmarkMallocLargeStruct     907           901           -0.66%
BenchmarkGobDecode             13235542      12036851      -9.06%
BenchmarkGobEncode             10639699      9539155       -10.34%
BenchmarkJSONEncode            25193036      21898922      -13.08%
BenchmarkJSONDecode            96104044      89464904      -6.91%

Fixes golang#8452.

LGTM=khr
R=golang-codereviews, bradfitz, rsc, dave, khr
CC=golang-codereviews
https://golang.org/cl/122090043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dvyukov @randall77 @gopherbot