Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug/dwarf: Linker emits DW_TAG _unspecified_type but debug/dwarf panics when encountering them #8437

Closed
gopherbot opened this issue Jul 28, 2014 · 9 comments
Closed

debug/dwarf: Linker emits DW_TAG _unspecified_type but debug/dwarf panics when encountering them #8437

gopherbot opened this issue Jul 28, 2014 · 9 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@gopherbot
Copy link

by parkerderek86:

When using the Reader from the debug/dwarf package on a Go 1.3 executable (compiled on
linux amd64) I encounter a panic whenever it tries to make sense of a
DW_TAG_unspecified_type DWARF tag.

This is a DWARF 3 tag, and is emitted by the linker, however never taken into account in
the debug/dwarf package.
@gopherbot
Copy link
Author

Comment 1 by parkerderek86:

Submitted a CL here: https://golang.org/cl/117280043/

@gopherbot
Copy link
Author

Comment 2:

CL https://golang.org/cl/117280043 mentions this issue.

@ianlancetaylor
Copy link
Contributor

Comment 3:

Labels changed: added repo-main, release-go1.3.1.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Aug 6, 2014

Comment 4:

Status changed to Started.

@bradfitz
Copy link
Contributor

bradfitz commented Aug 6, 2014

Comment 5:

This issue was closed by revision c0ccf6f.

Status changed to Fixed.

@ianlancetaylor
Copy link
Contributor

Comment 6:

See also followup CL: https://golang.org/cl/120700043/

@rsc
Copy link
Contributor

rsc commented Aug 11, 2014

Comment 7:

It is easy to copy and use the new debug/dwarf code.
I don't see the argument for inclusion in 1.3.1.

@ianlancetaylor
Copy link
Contributor

Comment 8:

The argument for 1.3.1 is that the 1.3 linker is generating code that the 1.3
debug/dwarf can not parse.
I agree it's definitely not required for 1.3.1 but the current status looks sloppy.

@rsc
Copy link
Contributor

rsc commented Aug 11, 2014

Comment 9:

I agree that it looks sloppy but it's not a critical bug. Most of debug/dwarf looks
sloppy, honestly (I can say that, because I wrote it).
In general we have tried to avoid adding new API in point releases. We don't even have
build tags for point releases. So there's no way to use the new type safely.
I don't think there are enough users of debug/dwarf to do this right now. Argue if you
disagree.

Labels changed: added release-go1.4, removed release-go1.3.1.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@derekparker @wheatman
debug/dwarf: fix Reader panic on DW_TAG_unspecified_type
6855bdb 
The linker currently produces the DWARF 3 DW_TAG_unspecified_type tag, however the Reader in debug/dwarf will panic whenever that tag is encountered.

Fixes golang#8437.

LGTM=rsc
R=golang-codereviews, bradfitz, iant, rsc
CC=golang-codereviews
https://golang.org/cl/117280043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@derekparker @wheatman
debug/dwarf: fix Reader panic on DW_TAG_unspecified_type
30d411c 
The linker currently produces the DWARF 3 DW_TAG_unspecified_type tag, however the Reader in debug/dwarf will panic whenever that tag is encountered.

Fixes golang#8437.

LGTM=rsc
R=golang-codereviews, bradfitz, iant, rsc
CC=golang-codereviews
https://golang.org/cl/117280043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
4 participants
@bradfitz @rsc @ianlancetaylor @gopherbot