Skip to content

x/sys/unix: add Msync #8245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jun 20, 2014 · 6 comments
Closed

x/sys/unix: add Msync #8245

gopherbot opened this issue Jun 20, 2014 · 6 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

go1.3 does not include a syscall.Msync wrapper. Writable mmaps are not currently usable
on darwin because it doesn't guarantee writeback to the file no munmap, only on explicit
msync.

I've tested that this works:

//sys Msync(b []byte, flags int) (err error)
@gopherbot
Copy link
Contributor Author

Comment 1:

*on* munmap

@bradfitz
Copy link
Contributor

Comment 2:

Would you like to send in a patch?
See http://golang.org/doc/contribute.html

Labels changed: added release-go1.4, repo-main.

@gopherbot
Copy link
Contributor Author

Comment 3:

I have not signed the CLA and probably won't. Sorry.

@rsc
Copy link
Contributor

rsc commented Sep 18, 2014

Comment 4:

Labels changed: added release-none, repo-sys, removed release-go1.4, repo-main.

Status changed to Accepted.

@mikioh mikioh changed the title go.sys/unix: Please add Msync unix: add Msync Jan 7, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title unix: add Msync x/sys/unix: add Msync Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-sys label Apr 14, 2015
@gopherbot
Copy link
Contributor Author

CL https://golang.org/cl/50891 mentions this issue.

@gopherbot
Copy link
Contributor Author

CL https://golang.org/cl/50892 mentions this issue.

gopherbot pushed a commit to golang/sys that referenced this issue Jul 25, 2017
@tklauser @ianlancetaylor
unix: add Msync function on Linux
d6d53c0 
Add the Msync function on Linux. See
http://man7.org/linux/man-pages/man2/msync.2.html

Updates golang/go#8245

Change-Id: I964259bafc8d4fbca09961443f21c4278bf56706
Reviewed-on: https://go-review.googlesource.com/50891
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
micanzhang pushed a commit to micanzhang/sys that referenced this issue Sep 12, 2017
@tklauser @micanzhang
unix: add Msync function on Linux
2231b50 
Add the Msync function on Linux. See
http://man7.org/linux/man-pages/man2/msync.2.html

Updates golang/go#8245

Change-Id: I964259bafc8d4fbca09961443f21c4278bf56706
Reviewed-on: https://go-review.googlesource.com/50891
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
micanzhang pushed a commit to micanzhang/sys that referenced this issue Sep 12, 2017
@tklauser @micanzhang
unix: add Msync function on Darwin
583b67b 
Add the Msync function on darwin/amd64 and darwin/386.

Fixes golang/go#8245

Change-Id: I1d234bb97731934c36d926ed2332c93b35b2f641
Reviewed-on: https://go-review.googlesource.com/50892
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @rsc @gopherbot