Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hash/crc32: clarify documentation #8229

Closed
gopherbot opened this issue Jun 18, 2014 · 4 comments
Closed

hash/crc32: clarify documentation #8229

gopherbot opened this issue Jun 18, 2014 · 4 comments
Labels
Documentation FrozenDueToAge
Milestone
Go1.5

Comments

@gopherbot
Copy link

by sheetjs:

Documentation currently says:

"MakeTable returns the Table constructed from the specified polynomial."

Somewhere in the doc, it should explicitly state that poly (the 32 bit integer) should
be based on the reversed representation.  It's implied by the constant "IEEE =
0xedb88320" (the normal representation for that case is 0x04c11db7), but making it
clear wouldn't hurt
@griesemer
Copy link
Contributor

Comment 1:

Labels changed: added repo-main, documentation.

@griesemer
Copy link
Contributor

Comment 2:

Owner changed to @agl.

@bradfitz bradfitz removed the new label Dec 18, 2014
@rsc rsc added this to the Go1.5Maybe milestone Apr 10, 2015
@rsc rsc removed the repo-main label Apr 14, 2015
@syst3mw0rm
Copy link
Contributor

gerrit code review link - https://go-review.googlesource.com/#/c/9237/

@gopherbot
Copy link
Author

CL https://golang.org/cl/9680 mentions this issue.

mk0x9 pushed a commit to mk0x9/go that referenced this issue May 4, 2015
@minux
hash/crc32: move reverse representation docs to an example
169adec 
Updates golang#8229.

Change-Id: I3e691479d3659ed1b3ff8ebbb71b4fc03f2e67af
Reviewed-on: https://go-review.googlesource.com/9680
Reviewed-by: Rob Pike <r@golang.org>
@mikioh mikioh modified the milestones: Go1.5, Go1.5Maybe May 15, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
6 participants
@bradfitz @mikioh @rsc @syst3mw0rm @griesemer @gopherbot