Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: provide no-vdso no-vsyscall fallback on linux/amd64 #8200

Closed
ianlancetaylor opened this issue Jun 13, 2014 · 8 comments
Closed

runtime: provide no-vdso no-vsyscall fallback on linux/amd64 #8200

ianlancetaylor opened this issue Jun 13, 2014 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Go1.9Maybe

Comments

@ianlancetaylor
Copy link
Contributor 

https://golang.org/issue/8197?c=30 says that if we can't find the
VDSO, we should use ordinary system calls, rather than the vsyscall fallback.
@rsc
Copy link
Contributor

rsc commented Sep 18, 2014

Comment 1:

Is this critical enough for 1.4 to be fixing at this late stage? I assume not.

Labels changed: added release-go1.5, removed release-go1.4.

@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@rsc rsc removed accepted labels Apr 14, 2015
@rsc rsc modified the milestones: Unplanned, Go1.5 Jul 21, 2015
@rminnich
Copy link
Contributor

This just got a bit important to me as there are kernels configured to no longer let you use vsyscalls at all. So Go won't run on those systems. Changing the config of said kernels is not an option, since vsyscalls are viewed as a security problem.

I can try to fix this but I want to see if (a) someone already has so I don't net to, or it not, (b) this is something people are open to changing should I try to fix it.

@bradfitz
Copy link
Contributor

/cc @ianlancetaylor, @randall77, @minux

@bradfitz bradfitz modified the milestones: Go1.8Maybe, Unplanned Sep 12, 2016
@minux
Copy link
Member

minux commented Sep 12, 2016 via email

@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 11, 2016
@rsc
Copy link
Contributor

rsc commented Oct 21, 2016

@rminnich, can you say more about what's available or how to detect that vsyscall (the 0xffffffffff600000 page) is not there? I'd really like to avoid going into the kernel for gettimeofday unless absolutely necessary (i.e., only on the crazy systems you are describing).

@rsc rsc changed the title runtime: if no VDSO, use normal syscalls, not the vsyscall page runtime: provide no-vdso no-vsyscall fallback on linux/amd64 Oct 21, 2016
@rsc
Copy link
Contributor

rsc commented Nov 2, 2016

Still waiting for reply from @rminnich, but work will not happen for Go 1.8.

@rsc rsc modified the milestones: Go1.9, Go1.8Maybe Nov 2, 2016
@aclements
Copy link
Member

Ping @rminnich.

@aclements aclements added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jun 9, 2017
@aclements aclements modified the milestones: Go1.9Maybe, Go1.9 Jun 9, 2017
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Jul 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Go1.9Maybe
Development

No branches or pull requests
8 participants
@bradfitz @rminnich @rsc @quentinmit @minux @aclements @ianlancetaylor @gopherbot