New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/cmd/benchcmp: warn about outliers for -best mode. #8182
Labels
Milestone
Comments
let me rephrase the criteria more formally: if the std. deviation of old or new data points is too large (compared to the value themselves), then warn. the problem is how large is too large? 100%? 50%? 30%? 10%? PS: the data is from the m to g->m change that I mentioned in the ARM NaCl design doc on golang-dev. |
Oh, so something like the coefficient of variation? Devising correct statistical tests is way out of my depth. As for how much is too much, I'd just naively observe a bunch of values from normal runs and hope that the right number is obvious. And in this case, I'd say false positives are better than false negatives. |
rsc
changed the title
go.tools/cmd/benchcmp: warn about outliers for -best mode.
x/tools/cmd/benchcmp: warn about outliers for -best mode.
Apr 14, 2015
This is a benchcmp issues that is solved by using benchstat, which is what we recommend now anyway. Closing here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: