Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go get -t A B may not get B's test deps #8181

Closed
rsc opened this issue Jun 11, 2014 · 3 comments
Closed

cmd/go: go get -t A B may not get B's test deps #8181

rsc opened this issue Jun 11, 2014 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@rsc
Copy link
Contributor

rsc commented Jun 11, 2014 

go get -t A B does not fetch B's test dependencies if A imports B, because the
processing of A already visited B and marked it as 'done'. This is a bug. It should
revisit B and get the dependencies.

https://twitter.com/nelhage/status/475685239428497409
https://twitter.com/nelhage/status/475687144464187392
@adg
Copy link
Contributor

adg commented Aug 7, 2014

Comment 1:

Owner changed to @adg.

Status changed to Started.

@gopherbot
Copy link
Contributor

Comment 2:

CL https://golang.org/cl/123870043 mentions this issue.

@adg
Copy link
Contributor

adg commented Aug 7, 2014

Comment 3:

This issue was closed by revision 10c2f56.

Status changed to Fixed.

@rsc rsc added fixed labels Aug 7, 2014
@rsc rsc assigned adg Aug 7, 2014
@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
rsc added a commit that referenced this issue Jun 22, 2015
@rsc
cmd/go: fix test for issue 8181
794c01b 
The test was translated from shell incorrectly,
and it depended on having hg installed, which
may not be the case.

Moved repo to GitHub, updated code, and fixed
go list ... command to be expected to succeed.

Fixes test for #8181.

Change-Id: I7f3e8fb20cd16cac5ed24de6fd952003bc5e08d4
Reviewed-on: https://go-review.googlesource.com/11301
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@adg @wheatman
cmd/go: download test dependencies of all named packages
d62f5d9 
Fixes golang#8181.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/123870043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@adg @wheatman
cmd/go: download test dependencies of all named packages
a19e03d 
Fixes golang#8181.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/123870043
@rsc rsc unassigned adg Jun 23, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
3 participants
@rsc @adg @gopherbot