Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509/pkix: TBSCertificateList.NextUpdate field is optional #8085

Closed
egonelbre opened this issue May 23, 2014 · 5 comments
Closed

crypto/x509/pkix: TBSCertificateList.NextUpdate field is optional #8085

egonelbre opened this issue May 23, 2014 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@egonelbre
Copy link
Contributor 

go version:
go version go1.3beta2 +708e129e91a9 Wed May 21 16:01:54 2014 -0700 windows/amd64

What steps reproduce the problem?

Use x509.ParseCRL on a CRL content that doesn't contain the nextUpdate field.

http://play.golang.org/p/C95xp9K9ei

The RFC5280 specifies TBSCertList as:

<pre>
  TBSCertList  ::=  SEQUENCE  {
        version                 Version OPTIONAL,
        signature               AlgorithmIdentifier,
        issuer                  Name,
        thisUpdate              Time,
        nextUpdate              Time OPTIONAL,
        ...
</pre>
@ianlancetaylor
Copy link
Contributor

Comment 1:

Labels changed: added repo-main, release-go1.4.

@agl
Copy link
Contributor

agl commented May 26, 2014

Comment 2:

Owner changed to @agl.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Sep 15, 2014

Comment 3:

agl - for 1.4 or postpone to 1.5?

@gopherbot
Copy link

Comment 4:

CL https://golang.org/cl/149770044 mentions this issue.

@agl
Copy link
Contributor

agl commented Sep 29, 2014

Comment 5:

This issue was closed by revision dfddd80.

Status changed to Fixed.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@agl @wheatman
crypto/x509: accept CRLs without an expiry.
7a63a28 
RFC5280 says that the nextUpdate field is optional.

Fixes golang#8085.

R=bradfitz
CC=golang-codereviews
https://golang.org/cl/149770044
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
@agl @wheatman
crypto/x509: accept CRLs without an expiry.
8c70ac1 
RFC5280 says that the nextUpdate field is optional.

Fixes golang#8085.

R=bradfitz
CC=golang-codereviews
https://golang.org/cl/149770044
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@agl @wheatman
crypto/x509: accept CRLs without an expiry.
8159867 
RFC5280 says that the nextUpdate field is optional.

Fixes golang#8085.

R=bradfitz
CC=golang-codereviews
https://golang.org/cl/149770044
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@agl @wheatman
crypto/x509: accept CRLs without an expiry.
c1ccf48 
RFC5280 says that the nextUpdate field is optional.

Fixes golang#8085.

R=bradfitz
CC=golang-codereviews
https://golang.org/cl/149770044
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
5 participants
@agl @rsc @egonelbre @ianlancetaylor @gopherbot