Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: a timeout error on tls.Conn.Write is confusing #8071

Open
mikioh opened this issue May 22, 2014 · 3 comments
Open

crypto/tls: a timeout error on tls.Conn.Write is confusing #8071

mikioh opened this issue May 22, 2014 · 3 comments
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Unplanned

Comments

@mikioh
Copy link
Contributor

mikioh commented May 22, 2014 

SetWriteDeadline of tls.Conn describes "A zero value for t means Write will not
time out. After a Write has timed out, the TLS state is corrupt and all future writes
will return the same error." but the returned value on timeout is marked Temporary
and it may be confusing.

A suggestion: https://groups.google.com/d/msg/golang-nuts/UChb8wv6gvA/9R_g4ScTMiYJ
@griesemer
Copy link
Contributor

Comment 1:

Labels changed: added release-none, repo-crypto.

@mikioh mikioh added new labels Oct 1, 2014
@bradfitz bradfitz removed the new label Dec 18, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@ysmolski
Copy link
Member

ysmolski commented Nov 6, 2018

The description in this issue is somewhat confusing. What is exactly proposed here?

@ysmolski ysmolski added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Nov 6, 2018
@mikioh
Copy link
Contributor Author

mikioh commented Nov 7, 2018 •
edited

The description in this issue is somewhat confusing.

Hm, I have never imagined it's confusing.

What is exactly proposed here?

My understanding from the discussion at golang-nuts is that the returned error value from tls.Conn should not be marked/colored "Temporary" when the underlying facilities are unable to provide communication functionality anymore.

In other words, a returned error value should represent the error, the definition is slightly different between SDOs, let's say it's "an incorrect internal state" here, precisely as much as possible for fault localization.

@ALTree ALTree added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
6 participants
@bradfitz @mikioh @rsc @ysmolski @ALTree @griesemer