Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql/driver: typo in comment for Stmt.Query in driver.go #8061

Closed
gopherbot opened this issue May 21, 2014 · 2 comments
Closed

database/sql/driver: typo in comment for Stmt.Query in driver.go #8061

gopherbot opened this issue May 21, 2014 · 2 comments
Labels
FrozenDueToAge

Comments

@gopherbot
Copy link

by dsavints:

What does 'go version' print?
go version go1.3beta2 +962157789bb0 Tue May 20 21:36:50 2014 -0700 darwin/amd64

What steps reproduce the problem?
http://tip.golang.org/src/pkg/database/sql/driver/driver.go?#L137

The comment for function Query says "// Exec executes a query" - surely,
cut-and-paste from the previous function
http://tip.golang.org/src/pkg/database/sql/driver/driver.go?#L133

What should have happened instead?
Comment should say "// Query executes a query [...]

Dmitry
@gopherbot
Copy link
Author

Comment 1:

CL https://golang.org/cl/93520046 mentions this issue.

@ianlancetaylor
Copy link
Contributor

Comment 2:

This issue was closed by revision 7d4cb4d.

Status changed to Fixed.

@mikioh mikioh changed the title typo in comment for Stmt.Query in database/sql/driver/driver.go database/sql/driver: typo in comment for Stmt.Query in driver.go Feb 18, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@ianlancetaylor @wheatman
database/sql/driver: correct method name in comment
df5cf7d 
Fixes golang#8061.

LGTM=crawshaw
R=golang-codereviews, crawshaw
CC=golang-codereviews
https://golang.org/cl/93520046
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianlancetaylor @gopherbot