Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug/plan9obj: review API #7989

Closed
rsc opened this issue May 13, 2014 · 3 comments
Closed

debug/plan9obj: review API #7989

rsc opened this issue May 13, 2014 · 3 comments
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented May 13, 2014

I don't understand why ExecTable is exported, nor Prog.
I also don't understand how, given a File, to determine the architecture.
@0intro
Copy link
Member

0intro commented May 13, 2014

Comment 1:

> I don't understand why ExecTable is exported, nor Prog.
ExecTable should probably not be exported.
> I also don't understand how, given a File, to determine the architecture.
What do you think of this:
- make ?_MAGIC variables public
- add "Prog *Prog" in File structure
This way, the full program header would be public, and one could
compare f.Prog.Magic to ?_MAGIC to determine the architecture.
Alternatively, we could add "Magic string" in FileHeader.
Does it sound good?
Thanks.

Owner changed to @0intro.

@gopherbot
Copy link

Comment 2:

CL https://golang.org/cl/91400044 mentions this issue.

@0intro
Copy link
Member

0intro commented May 20, 2014

Comment 3:

This issue was closed by revision b28aa1f.

Status changed to Fixed.

@rsc rsc added fixed labels May 20, 2014
@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants