Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: access names of the registered drivers #7969

Closed
gopherbot opened this issue May 11, 2014 · 4 comments
Closed

database/sql: access names of the registered drivers #7969

gopherbot opened this issue May 11, 2014 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@gopherbot
Copy link

by weberc2:

I'd like to be able to determine at runtime which drivers are registered.
@bradfitz
Copy link
Contributor

Comment 1:

Labels changed: added release-go1.4, repo-main.

Status changed to Accepted.

@gopherbot
Copy link
Author

Comment 2 by weberc2:

I pushed an initial code review here: https://golang.org/cl/91350043/
However, I would like some feedback on the function signature (should
RegisteredDrivers() return []string or map[string]driver.Driver? Or should the name be
something more along the lines of RegisteredDriverNames()?) Here's the link for the
discussion on this issue: https://groups.google.com/forum/#!topic/golang-nuts/6nBDvrOJBAw

@gopherbot
Copy link
Author

Comment 4:

CL https://golang.org/cl/158950043 mentions this issue.

@rsc
Copy link
Contributor

rsc commented Oct 15, 2014

Comment 5:

This issue was closed by revision 5318a1b.

Status changed to Fixed.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@rsc @wheatman
database/sql: add Drivers, returning list of registered drivers
0ead70b 
Fixes golang#7969.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/158950043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
@rsc @wheatman
database/sql: add Drivers, returning list of registered drivers
14b362d 
Fixes golang#7969.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/158950043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@rsc @wheatman
database/sql: add Drivers, returning list of registered drivers
6b85e1a 
Fixes golang#7969.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/158950043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@rsc @wheatman
database/sql: add Drivers, returning list of registered drivers
cde1611 
Fixes golang#7969.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/158950043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
3 participants
@bradfitz @rsc @gopherbot