Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.tools/go/types: initialization order of independent variables is not in declaration order #7964

Closed
griesemer opened this issue May 9, 2014 · 6 comments
Closed

go.tools/go/types: initialization order of independent variables is not in declaration order #7964

griesemer opened this issue May 9, 2014 · 6 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@griesemer
Copy link
Contributor 

http://play.golang.org/p/k9XerraTf8

Got: b c d a

Want: a b c d

gc produces: c b d a (but a, b, c, are independent, so they should be in order a b c)
gccgo produces: a b c d (correct)

Fix for 1.3 is fix is trivial (a couple of lines), otherwise leave for 1.4.
@rsc
Copy link
Contributor

rsc commented May 11, 2014

Comment 1:

Not blocking the release because I don't believe any released binaries depend on
initialization order. (Godoc uses go/types but not this part.)

Labels changed: added release-none, removed release-go1.3maybe.

@gopherbot
Copy link

Comment 2:

CL https://golang.org/cl/91450043 mentions this issue.

@griesemer
Copy link
Contributor Author

Comment 3:

Fix is non-trivial but contained. Decide if acceptable for 1.3.

Labels changed: added release-go1.3maybe, removed release-none.

Status changed to Started.

@rsc
Copy link
Contributor

rsc commented May 19, 2014

Comment 4:

I don't believe the bug affects any tools in the 1.3 release (please correct me if I'm
wrong), but the fix might introduce a different bug that might. We're very close to
release; let's wait on the CL.

Labels changed: added release-none, removed release-go1.3maybe.

@griesemer
Copy link
Contributor Author

Comment 5:

Labels changed: added release-go1.4, removed release-none.

@griesemer
Copy link
Contributor Author

Comment 6:

This issue was closed by revision golang/tools@3827909.

Status changed to Fixed.

@griesemer griesemer self-assigned this Jun 11, 2014
@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
3 participants
@rsc @griesemer @gopherbot