Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/rpc: add client support for RPC over HTTPS #7946

Closed
athomason opened this issue May 6, 2014 · 5 comments
Closed

net/rpc: add client support for RPC over HTTPS #7946

athomason opened this issue May 6, 2014 · 5 comments

Comments

@athomason
Copy link

While net/rpc supports HTTPS trivially in the server, there's no built-in way for a
client to connect to one since rpc.DialHTTPPath calls net.Dial itself. With some
duplicated code from client.go it's possible to create a working DialHTTPSPath in user
code, though this is suboptimal since DialHTTPPath references an unexported package
variable which must be duplicated.

https://golang.org/cl/100140043 implements rpc.DialHTTPS and rpc.DialHTTPSPath
which are exact analogues to DialHTTP and DialHTTPPath apart from also accepting a
tls.Config. This issue is mainly to track that CL during the 1.3 code freeze.

I originally proposed this at
https://groups.google.com/forum/#!topic/golang-nuts/M0LwsijM9bo; no objections were
offered.
@bradfitz
Copy link
Contributor

bradfitz commented May 6, 2014

Comment 1:

Labels changed: added release-go1.4, repo-main.

Status changed to Accepted.

@gopherbot
Copy link

Comment 2:

CL https://golang.org/cl/100140043 mentions this issue.

@robpike
Copy link
Contributor

robpike commented Oct 13, 2014

Comment 3:

Labels changed: added release-go1.5, removed release-go1.4.

@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@rsc rsc removed accepted labels Apr 14, 2015
@rsc rsc modified the milestones: Unplanned, Go1.5 Jul 15, 2015
@gopherbot
Copy link

CL https://golang.org/cl/17271 mentions this issue.

@robpike
Copy link
Contributor

robpike commented Oct 26, 2016

The net/rpc package is frozen, so closing this.

@robpike robpike closed this as completed Oct 26, 2016
@golang golang locked and limited conversation to collaborators Oct 26, 2017
@rsc rsc unassigned robpike Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants