Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: useless error when assembly file doesn't end in newline #7890

Closed
bradfitz opened this issue Apr 28, 2014 · 2 comments
Closed

cmd/go: useless error when assembly file doesn't end in newline #7890

bradfitz opened this issue Apr 28, 2014 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@bradfitz
Copy link
Contributor 

1) make a foo_amd64.s with only "# hi" in it (no trailing newline)

2) make a foo.go file, package foo

2) go build .


Output is unhelpfully:

$ go build .
# foo
eof in comment

It should say which file at least.
@rsc
Copy link
Contributor

rsc commented Sep 26, 2014

Comment 1:

I agree, it should, but the assembler is going to be replaced next cycle so it's
probably not worth the effort. I looked and it's not trivial.

Labels changed: added release-go1.5, removed release-go1.4.

@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@rsc rsc removed accepted labels Apr 14, 2015
@rsc
Copy link
Contributor

rsc commented Apr 20, 2015

I checked that cmd/asm gets this right. cmd/old6a etc will be deleted for the final release, which will solve this.
Therefore, duplicate of #10510.

@rsc rsc closed this as completed Apr 20, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
3 participants
@bradfitz @rsc @gopherbot