Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/nm: TestNM fails #7829

Closed
alexbrainman opened this issue Apr 21, 2014 · 8 comments
Closed

cmd/nm: TestNM fails #7829

alexbrainman opened this issue Apr 21, 2014 · 8 comments
Milestone

Comments

@alexbrainman
Copy link
Member

New TestNM fails on some builders (darwin/race, linux/race and solaris/amd64):

--- FAIL: TestNM (1.69 seconds)
    nm_test.go:27: nm must have at least 3 columns
    nm_test.go:27: nm must have at least 3 columns
    nm_test.go:27: nm must have at least 3 columns
    nm_test.go:27: nm must have at least 3 columns
    nm_test.go:27: nm must have at least 3 columns
    nm_test.go:27: nm must have at least 3 columns
...

I don't know why, and don't have access to ether system to investigate.

Alex
@dvyukov
Copy link
Member

dvyukov commented Apr 21, 2014

Comment 1:

maybe it prints a data race
try to run with -race

@gopherbot
Copy link

Comment 2:

CL https://golang.org/cl/89810043 mentions this issue.

@davecheney
Copy link
Contributor

Comment 3:

It looks like race builds (because the test binary is built with -race), include
additional undefined symbols.
--- FAIL: TestNM (0.55 seconds)
        nm_test.go:27: line 872: nm must have at least 3 columns, got ["U" "__errno_location"]
        nm_test.go:27: line 873: nm must have at least 3 columns, got ["U" "__libc_free"]
        nm_test.go:27: line 874: nm must have at least 3 columns, got ["U" "__libc_mallinfo"]
        nm_test.go:27: line 875: nm must have at least 3 columns, got ["U" "__libc_malloc"]
        nm_test.go:27: line 876: nm must have at least 3 columns, got ["U" "__libc_stack_end"]
        nm_test.go:27: line 910: nm must have at least 3 columns, got ["U" "abort"]
        nm_test.go:27: line 1111: nm must have at least 3 columns, got ["U" "confstr"]
        nm_test.go:27: line 1586: nm must have at least 3 columns, got ["U" "dl_iterate_phdr"]
        nm_test.go:27: line 1688: nm must have at least 3 columns, got ["U" "exit"]
        nm_test.go:27: line 1957: nm must have at least 3 columns, got ["U" "fprintf"]
        nm_test.go:27: line 1958: nm must have at least 3 columns, got ["U" "free"]
        nm_test.go:27: line 1962: nm must have at least 3 columns, got ["U" "fwrite"]
        nm_test.go:27: line 1975: nm must have at least 3 columns, got ["U" "getrlimit"]
        nm_test.go:27: line 1976: nm must have at least 3 columns, got ["U" "getuid"]
        nm_test.go:27: line 2144: nm must have at least 3 columns, got ["U" "isatty"]
        nm_test.go:27: line 2174: nm must have at least 3 columns, got ["U" "madvise"]
        nm_test.go:27: line 2192: nm must have at least 3 columns, got ["U" "malloc"]
        nm_test.go:27: line 2479: nm must have at least 3 columns, got ["U" "prctl"]
        nm_test.go:27: line 2488: nm must have at least 3 columns, got ["U" "pthread_attr_destroy"]
        nm_test.go:27: line 2489: nm must have at least 3 columns, got ["U" "pthread_attr_getstacksize"]
        nm_test.go:27: line 2490: nm must have at least 3 columns, got ["U" "pthread_attr_init"]
        nm_test.go:27: line 2491: nm must have at least 3 columns, got ["U" "pthread_create"]
        nm_test.go:27: line 2492: nm must have at least 3 columns, got ["U" "pthread_self"]
        nm_test.go:27: line 2493: nm must have at least 3 columns, got ["U" "pthread_sigmask"]
        nm_test.go:27: line 4222: nm must have at least 3 columns, got ["U" "setenv"]
        nm_test.go:27: line 4225: nm must have at least 3 columns, got ["U" "setrlimit"]
        nm_test.go:27: line 4231: nm must have at least 3 columns, got ["U" "sigfillset"]
        nm_test.go:27: line 4234: nm must have at least 3 columns, got ["U" "sleep"]
        nm_test.go:27: line 4263: nm must have at least 3 columns, got ["U" "stderr"]
        nm_test.go:27: line 4368: nm must have at least 3 columns, got ["U" "strerror"]
        nm_test.go:27: line 5927: nm must have at least 3 columns, got ["U" "usleep"]
FAIL
exit status 1
FAIL    cmd/nm  0.562s

Labels changed: added release-go1.3, repo-main.

Status changed to Accepted.

@alexbrainman
Copy link
Member Author

Comment 4:

This issue was updated by revision 6a40d54.

LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/89810043

@alexbrainman
Copy link
Member Author

Comment 5:

Maybe I should just ignore "3 columns" test? If it fails, just continue onto the next
line?
Alex

@davecheney
Copy link
Contributor

Comment 6:

I think it would be ok to skip those lines, but I'm not a linker expert. Iant or minux
can probably give a clearer direction.

@gopherbot
Copy link

Comment 7:

CL https://golang.org/cl/89830043 mentions this issue.

@alexbrainman
Copy link
Member Author

Comment 8:

This issue was closed by revision 296eeaa.

Status changed to Fixed.

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants