Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/asn1: marshaling ignores the default value for optional elements. #7780

Closed
agl opened this issue Apr 14, 2014 · 3 comments
Closed

encoding/asn1: marshaling ignores the default value for optional elements. #7780

agl opened this issue Apr 14, 2014 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@agl
Copy link
Contributor

agl commented Apr 14, 2014 

https://groups.google.com/d/msg/Golang-nuts/9Ss6o9CW-Yo/KL_V7hFlyOAJ
@gopherbot
Copy link

Comment 1:

CL https://golang.org/cl/86960045 mentions this issue.

@bradfitz
Copy link
Contributor

Comment 2:

Labels changed: added release-go1.4, removed release-go1.3maybe.

@agl
Copy link
Contributor Author

agl commented Jul 28, 2014

Comment 3:

This issue was closed by revision 8332112.

Status changed to Fixed.

@agl agl added fixed labels Jul 28, 2014
@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@agl @wheatman
encoding/asn1: only omit optional elements matching default value.
2e43880 
ASN.1 elements can be optional, and can have a default value.
Traditionally, Go has omitted elements that are optional and that have
the zero value. I believe that's a bug (see [1]).

This change causes an optional element with a default value to only be
omitted when it has that default value. The previous behaviour of
omitting optional, zero elements with no default is retained because
it's used quite a lot and will break things if changed.

[1] https://groups.google.com/d/msg/Golang-nuts/9Ss6o9CW-Yo/KL_V7hFlyOAJ

Fixes golang#7780.

R=bradfitz

LGTM=bradfitz
R=golang-codereviews, bradfitz, rsc
CC=golang-codereviews, r
https://golang.org/cl/86960045
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@agl @wheatman
encoding/asn1: only omit optional elements matching default value.
b1d9927 
ASN.1 elements can be optional, and can have a default value.
Traditionally, Go has omitted elements that are optional and that have
the zero value. I believe that's a bug (see [1]).

This change causes an optional element with a default value to only be
omitted when it has that default value. The previous behaviour of
omitting optional, zero elements with no default is retained because
it's used quite a lot and will break things if changed.

[1] https://groups.google.com/d/msg/Golang-nuts/9Ss6o9CW-Yo/KL_V7hFlyOAJ

Fixes golang#7780.

R=bradfitz

LGTM=bradfitz
R=golang-codereviews, bradfitz, rsc
CC=golang-codereviews, r
https://golang.org/cl/86960045
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
4 participants
@bradfitz @agl @rsc @gopherbot