Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image: add AtRGBA, AtGray16, etc. methods symmetric with SetRGBA, SetGray16, etc. #7694

Closed
nigeltao opened this issue Apr 3, 2014 · 2 comments
Closed

image: add AtRGBA, AtGray16, etc. methods symmetric with SetRGBA, SetGray16, etc. #7694

nigeltao opened this issue Apr 3, 2014 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@nigeltao
Copy link
Contributor

nigeltao commented Apr 3, 2014 

The image.Image and draw.Image interfaces define At and Set in terms of color.Color, an
interface type.

The concrete image implementations image.RGBA, image.Gray16, etc. also define SetRGBA,
SetGray16 etc. for performance compared to a vanilla Set.

We should consider also providing AtRGBA, AtGray16, etc.
@gopherbot
Copy link

Comment 1:

CL https://golang.org/cl/109000049 mentions this issue.

@nigeltao
Copy link
Contributor Author

Comment 2:

This issue was closed by revision ca94064.

Status changed to Fixed.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@chai2010 @wheatman
image: add RGBAAt, Gray16At, etc.
4e7310b 
Fixes golang#7694.

LGTM=nigeltao, rsc, r
R=golang-codereviews, nigeltao, rsc, r
CC=golang-codereviews
https://golang.org/cl/109000049
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
3 participants
@rsc @nigeltao @gopherbot