Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: dragonfly bsd very flaky #7685

Closed
mikioh opened this issue Apr 2, 2014 · 3 comments
Closed

net/http: dragonfly bsd very flaky #7685

mikioh opened this issue Apr 2, 2014 · 3 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.

Comments

@mikioh
Copy link
Contributor

mikioh commented Apr 2, 2014

A few nil pointer deref. crashes and socket leaks in test cases have been seen during
struggling against DragonFly BSD network stack. Not sure it's worth to fix, just a
reminder.

Typical cases (mostly in serve_test.go and transport_test.go):

// No response.Body.Close
resp, err := Get(ts.URL)
if err != nil {
        t.Fatal(err)
}
body, err := ioutil.ReadAll(resp.Body)  

// Wild access to resp.Body
resp, err := c.Get(ts.URL)
if err != nil {
        t.Error(err)
}
ioutil.ReadAll(resp.Body)
@ianlancetaylor
Copy link
Contributor

Comment 2:

Labels changed: added release-go1.3maybe, os-dragonfly.

@rsc
Copy link
Contributor

rsc commented Apr 3, 2014

Comment 3:

Labels changed: added release-none, suggested, removed release-go1.3maybe.

Status changed to Accepted.

@mikioh mikioh added accepted Suggested Issues that may be good for new contributors looking for work to do. labels Apr 3, 2014
@mikioh
Copy link
Contributor Author

mikioh commented Jan 21, 2015

Nope. This is not a dragonfly-specific issue. Merged into #9161.

@mikioh mikioh closed this as completed Jan 21, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Development

No branches or pull requests

4 participants