Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestTLSServerClosesConnection is flaky #7634

Closed
bradfitz opened this issue Mar 25, 2014 · 7 comments
Closed

net/http: TestTLSServerClosesConnection is flaky #7634

bradfitz opened this issue Mar 25, 2014 · 7 comments
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.10

Comments

@bradfitz
Copy link
Contributor 

TestTLSServerClosesConnection is flaky on Windows.

Investigate why & re-enable.
@bradfitz
Copy link
Contributor Author

Comment 1:

This issue was updated by revision aa2d4de.

LGTM=alex.brainman
R=adg, alex.brainman
CC=golang-codereviews
https://golang.org/cl/80110043

@rsc
Copy link
Contributor

rsc commented May 21, 2014

Comment 2:

Labels changed: added release-go1.4.

@rsc
Copy link
Contributor

rsc commented Sep 16, 2014

Comment 3:

Labels changed: added release-none, removed release-go1.4.

@bradfitz bradfitz self-assigned this Sep 16, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@bradfitz bradfitz mentioned this issue Feb 2, 2016
Closed
@bradfitz bradfitz changed the title net/http: TestTLSServerClosesConnection is flaky on Windows net/http: TestTLSServerClosesConnection is flaky Feb 2, 2016
@bradfitz
Copy link
Contributor Author

bradfitz commented Feb 2, 2016

Also failed on Darwin. Details in #14195

@bradfitz bradfitz modified the milestones: Go1.9, Unplanned Feb 1, 2017
@bradfitz bradfitz added the Testing An issue that has been verified to require only test changes, not just a test failure. label Feb 1, 2017
@bradfitz
Copy link
Contributor Author

bradfitz commented Jul 7, 2017

Ran 200 runs on macOS Sierra: no problems. All pass 20/20:

=== RUN   TestTLSServerClosesConnection
--- PASS: TestTLSServerClosesConnection (0.05s)
	transport_test.go:2460: successes = 20 of 20
=== RUN   TestTLSServerClosesConnection
--- PASS: TestTLSServerClosesConnection (0.05s)
	transport_test.go:2460: successes = 20 of 20
=== RUN   TestTLSServerClosesConnection
--- PASS: TestTLSServerClosesConnection (0.05s)
	transport_test.go:2460: successes = 20 of 20
=== RUN   TestTLSServerClosesConnection
--- PASS: TestTLSServerClosesConnection (0.05s)
	transport_test.go:2460: successes = 20 of 20
=== RUN   TestTLSServerClosesConnection
--- PASS: TestTLSServerClosesConnection (0.05s)
	transport_test.go:2460: successes = 20 of 20
=== RUN   TestTLSServerClosesConnection
--- PASS: TestTLSServerClosesConnection (0.06s)
	transport_test.go:2460: successes = 20 of 20
=== RUN   TestTLSServerClosesConnection
--- PASS: TestTLSServerClosesConnection (0.06s)
	transport_test.go:2460: successes = 20 of 20
=== RUN   TestTLSServerClosesConnection
--- PASS: TestTLSServerClosesConnection (0.06s)
	transport_test.go:2460: successes = 20 of 20
PASS
ok  	net/http	10.796s

Likewise with gomote on a windows-amd64-2012 instance.

Maybe this is no longer flaky.

@broady broady modified the milestones: Go1.9Maybe, Go1.9 Jul 17, 2017
@bradfitz bradfitz modified the milestones: Go1.9Maybe, Go1.10 Jul 20, 2017
@bradfitz
Copy link
Contributor Author

bradfitz commented Dec 7, 2017

Closing until there are reports that this still happens.

@bradfitz bradfitz closed this as completed Dec 7, 2017
@gopherbot
Copy link

Change https://golang.org/cl/121735 mentions this issue: all: update stale test skips

gopherbot pushed a commit that referenced this issue Aug 20, 2018
@mvdan
all: update stale test skips
9e4d87d 
Issues #10043, #15405, and #22660 appear to have been fixed, and
whatever tests I could run locally do succeed, so remove the skips.

Issue #7237 was closed in favor of #17906, so update its skip line.

Issue #7634 was closed as it had not appeared for over three years.
Re-enable it for now. An issue should be open if the test starts being
skipped again.

Change-Id: I67daade906744ed49223291035baddaad9f56dca
Reviewed-on: https://go-review.googlesource.com/121735
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Jun 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
4 participants
@bradfitz @broady @rsc @gopherbot