x/playground: add vet #7597

josharian · 2014-03-20T16:41:56Z

On potential pain of button overload, it might be useful to add a Vet button to the
playground. It would run go vet over the program and display the output. This would
increase vet visibility and help make self-service debugging easier. (E.g. It would have
helped with https://groups.google.com/forum/m/#!topic/golang-nuts/IneZcyGGJYM )

adg · 2014-03-21T03:22:21Z

Comment 1:

Not a bad idea.

Owner changed to @adg.

Status changed to Accepted.

adg · 2014-03-31T03:08:00Z

Comment 2:

Labels changed: added repo-playground, release-none.

josharian · 2014-05-30T00:46:18Z

Comment 3:

Is this something that I can work on? If so, do you mind pointing me in the right
direction? (Where is the relevant codebase? Anything I need to be aware of for
testing/portability to the hosted playground environment?)

adg · 2014-05-30T00:51:55Z

Comment 4:

Please go ahead.
http://code.google.com/p/go-playground is where the code lives. Take a look at how the
fmt handler works. It would be similar to that.

josharian · 2014-05-30T04:23:26Z

Comment 5:

Thanks. The front-end part was surprisingly pleasant and straightforward.
Sadly, the rest is going to be disruptive. It will require converting vet into a
package. I have a couple of vet modules queued for 1.4. Once those land (or crash), I'll
email golang-dev to see how folks feel about turning vet into a package.

Owner changed to @josharian.

Status changed to Started.

cookieo9 · 2014-07-09T12:37:53Z

Comment 6:

I like this as it would hopefully reduce some of the traffic to golang-nuts.
It would also be nice if there was a race option for the run button, like the imports
option on the Format button. It would hopefully have a similar effect to bring more
visibility to the race-detector.
That may not be possible though, since the race detector probably won't work on the
playground platform. AFAIK it only works on 64-bit darwin/linux/windows/freebsd, while
the playground is nacl/386 I believe.

minux · 2014-07-09T15:20:27Z

Comment 7:

FYI, the playground is nacl/amd64p32.
Due to the way the race detector works and nacl works, it's impossible
to support the race detector on nacl.

josharian · 2015-01-09T19:46:53Z

The front-end work I did for this (now perhaps a bit dated) can be found at https://codereview.appspot.com/103750044/ and https://codereview.appspot.com/104770043/. The hard part--splitting vet into a package and a command--is still outstanding.

adg · 2015-01-11T23:11:39Z

Now that the new sandbox server is running on a VM, we can think about just
calling the vet command directly.

On 10 January 2015 at 06:47, Josh Bleecher Snyder notifications@github.com
wrote:

The front-end work I did for this (now perhaps a bit dated) can be found
at https://codereview.appspot.com/103750044/ and
https://codereview.appspot.com/104770043/. The hard part--splitting vet
into a package and a command--is still outstanding.

—
Reply to this email directly or view it on GitHub
#7597 (comment).

ucirello · 2015-06-30T05:39:12Z

Running playground on a sandbox makes easier to execute cmd/vet on a piece of code.

These two CLs addresses this issue, by updating both sandbox, playground frontend application and a static file shared with godoc.

Currently, it is implemented following this way:
1 - Added one entry point (/vet) to sandbox, which calls cmd/vet and parses the result as if it were a compilation process.
2 - Updated playground.js, so it calls /vet at backend.
3 - Updated Dockerfile with go get to install cmd/vet

I considered the alternative of overloading /compile endpoint with a parameter, thus switching back and forth between compilation and vetting. The reason I did not do it was that it seemed a cleaner design to keep separated different resources with different goals.

Of course, I am ready to change the implementation after debate.

Anyway, I should like to open as soon as possible another CL updating docs to mention the existence of a proxy at golang.org/compile - so other contributos do not get lost on why query-string calls are made where the sandbox expects for JSON.

https://go-review.googlesource.com/#/c/11632/
https://go-review.googlesource.com/#/c/11633/

ucirello · 2015-06-30T20:28:50Z

@adg ping

ucirello · 2015-06-30T20:29:03Z

@josharian ping.

gopherbot · 2015-06-30T22:00:59Z

CL https://golang.org/cl/11633 mentions this issue.

gopherbot · 2015-06-30T22:01:02Z

CL https://golang.org/cl/11632 mentions this issue.

adg · 2015-07-01T00:28:42Z

Sorry, I'm busy preparing for GopherCon. I will review this after next week.

On 1 July 2015 at 08:01, GopherBot notifications@github.com wrote:

CL https://golang.org/cl/11633 mentions this issue.

—
Reply to this email directly or view it on GitHub
#7597 (comment).

ucirello · 2015-07-27T06:22:47Z

@adg Sorry to bother you, could you please take a look at these CLs?

https://golang.org/cl/11633
https://golang.org/cl/11632

adg · 2015-07-28T03:10:39Z

After Go 1.5 is out, yes.

On 27 July 2015 at 16:23, Carlos Cirello notifications@github.com wrote:

@adg https://github.com/adg Sorry to bother you, could you please take
a look at these CLs?

https://golang.org/cl/11633
https://golang.org/cl/11632

—
Reply to this email directly or view it on GitHub
#7597 (comment).

ysmolski · 2018-03-14T09:24:42Z

I am working on it. Please give me early feedback if you have it.

/CC @andybons @bradfitz

andybons · 2018-03-14T15:28:02Z

UI lgtm!

gopherbot · 2018-03-14T21:14:19Z

Change https://golang.org/cl/100775 mentions this issue: godoc: add vet support for playground

gopherbot · 2018-03-14T21:35:06Z

Change https://golang.org/cl/100776 mentions this issue: playground: add vet

Playground needs godoc to support calls to /vet endpoint in playground.js. Optional parameter "vetEl" is added to the function "playground". If it's passed then the js installs the click handler to the element. There is a corresponding CL 100776 for the playground code. Updates golang/go#7597 Change-Id: Ica2e7cb9d76f6f19a1805c182e666b8142762da9 Reviewed-on: https://go-review.googlesource.com/100775 Reviewed-by: Andrew Bonventre <andybons@golang.org>

ysmolski · 2018-04-03T09:19:59Z

Reviewers are welcome here: https://golang.org/cl/100776

gopherbot · 2018-04-16T17:02:34Z

Change https://golang.org/cl/107455 mentions this issue: godoc: display "go vet" errors before the output of a program

This change adds an option to run "go vet" for the playground program and display errors before any output. To enable this, the playground function has to be supplied with opts.enableVet set to true. Vet check is performed only for succesfully run programs, meaning that the "/compile" endpoint returned no errors. This change highlights lines printed to stderr as errors (in red). There is a corresponding change for the Playground: CL 100776. Updates golang/go#7597 Updates golang/go#24576 Change-Id: I8c0f8c1189c461338b5bce57777b12aecab268fb Reviewed-on: https://go-review.googlesource.com/107455 Run-TryBot: Yury Smolsky <yury@smolsky.by> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org>

josharian added started labels Jul 9, 2014

rsc added this to the Unplanned milestone Apr 10, 2015

rsc removed the release-none label Apr 10, 2015

rsc changed the title ~~playground: add vet~~ x/playground: add vet Apr 14, 2015

rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015

rsc removed the repo-playground label Apr 14, 2015

adg mentioned this issue Aug 24, 2015

fmt: Printf %d printing functions as integers confuses newbies #12295

Closed

bradfitz removed the Started label Jan 6, 2017

andybons added the NeedsFix label Mar 14, 2018

ysmolski mentioned this issue Mar 26, 2018

x/playground: clean up the common code in handleVet and handleCompile #24535

Closed

gopherbot closed this as completed in golang/playground@da85333 May 8, 2018

golang locked and limited conversation to collaborators May 8, 2019

gopherbot added the FrozenDueToAge label May 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/playground: add vet #7597

x/playground: add vet #7597

josharian commented Mar 20, 2014

adg commented Mar 21, 2014

adg commented Mar 31, 2014

josharian commented May 30, 2014

adg commented May 30, 2014

josharian commented May 30, 2014

cookieo9 commented Jul 9, 2014

minux commented Jul 9, 2014

josharian commented Jan 9, 2015

adg commented Jan 11, 2015

ucirello commented Jun 30, 2015

ucirello commented Jun 30, 2015

ucirello commented Jun 30, 2015

gopherbot commented Jun 30, 2015

gopherbot commented Jun 30, 2015

adg commented Jul 1, 2015

ucirello commented Jul 27, 2015

adg commented Jul 28, 2015

ysmolski commented Mar 14, 2018

andybons commented Mar 14, 2018

gopherbot commented Mar 14, 2018

gopherbot commented Mar 14, 2018

ysmolski commented Apr 3, 2018

gopherbot commented Apr 16, 2018

x/playground: add vet #7597

x/playground: add vet #7597

Comments

josharian commented Mar 20, 2014

adg commented Mar 21, 2014

adg commented Mar 31, 2014

josharian commented May 30, 2014

adg commented May 30, 2014

josharian commented May 30, 2014

cookieo9 commented Jul 9, 2014

minux commented Jul 9, 2014

josharian commented Jan 9, 2015

adg commented Jan 11, 2015

ucirello commented Jun 30, 2015

ucirello commented Jun 30, 2015

ucirello commented Jun 30, 2015

gopherbot commented Jun 30, 2015

gopherbot commented Jun 30, 2015

adg commented Jul 1, 2015

ucirello commented Jul 27, 2015

adg commented Jul 28, 2015

ysmolski commented Mar 14, 2018

andybons commented Mar 14, 2018

gopherbot commented Mar 14, 2018

gopherbot commented Mar 14, 2018

ysmolski commented Apr 3, 2018

gopherbot commented Apr 16, 2018