Skip to content

time: Time should implement the Generator interface from test/quick #7588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 19, 2014 · 1 comment
Closed

time: Time should implement the Generator interface from test/quick #7588

gopherbot opened this issue Mar 19, 2014 · 1 comment
Labels
FrozenDueToAge

Comments

@gopherbot
Copy link
Contributor

by ryanslade:

Currently, when trying to call quick.Value on a struct that contains time.Time fields it
panics.

This happens because time.Time has unexported fields and does not implement the
quick.Generator interface.
@bradfitz
Copy link
Contributor

Comment 1:

Not possible: the time package can't depend on reflect. reflect is too high-level, and
time is too low-level. (See go/build/deps_test.go for the details).
Also, testing/quick is barely used. It probably wouldn't exist in a hypothetical Go 2.

Status changed to WontFix.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot