Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestClientWithIncorrectTLSServerName is broken #7456

Closed
alexbrainman opened this issue Mar 4, 2014 · 5 comments
Closed

net/http: TestClientWithIncorrectTLSServerName is broken #7456

alexbrainman opened this issue Mar 4, 2014 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1.3

Comments

@alexbrainman
Copy link
Member 

C:\go\root\src>go test -run=IncorrectTLSServerName -v net/http
=== RUN TestClientWithIncorrectTLSServerName
--- FAIL: TestClientWithIncorrectTLSServerName (0.55 seconds)
        client_test.go:675: expected an error log message containing 'bad certificate'; got "http: TLS handshake error from 127.0.0.1:1508: WSARecv tcp 127.0.0.1:1507: An existing connection was forcibly closed by the remote host.\n"
FAIL
exit status 1
FAIL    net/http        1.547s

C:\go\root\src>hg id
2750cd9fc49b tip

I use windows/386

Alex
@bradfitz
Copy link
Contributor

bradfitz commented Mar 4, 2014

Comment 1:

Works for me on Mac and Linux. And the Windows builder at build.golang.org.
Is this a MITM SSL proxy virus scanner issue?

@alexbrainman
Copy link
Member Author

Comment 2:

I don't know why it fails. I will investigate.
Alex

@alexbrainman
Copy link
Member Author

Comment 3:

http://build.golang.org/log/b7b17ef29771f54d3ad2958e46d8d1076414abcf
It happens on windows-amd64-race too.
Alex

@bradfitz
Copy link
Contributor

bradfitz commented Mar 4, 2014

Comment 4:

Sent https://golang.org/cl/70010050

Labels changed: added release-go1.3, repo-main.

Owner changed to @bradfitz.

Status changed to Started.

@bradfitz
Copy link
Contributor

bradfitz commented Mar 4, 2014

Comment 5:

This issue was closed by revision a5166a9.

Status changed to Fixed.

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.3
Development

No branches or pull requests
4 participants
@bradfitz @rsc @gopherbot @alexbrainman