Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: make nsec in time.Time an int32 when GC is precise #7446

Closed
alberts opened this issue Mar 3, 2014 · 5 comments
Closed

time: make nsec in time.Time an int32 when GC is precise #7446

alberts opened this issue Mar 3, 2014 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@alberts
Copy link
Contributor

alberts commented Mar 3, 2014 

If possible, include a link to a program on play.golang.org.

I was just browsing through the code for time.Time and found this:

// TODO(rsc): When the garbage collector is completely
// precise, change back to int32.
nsec uintptr

Which version are you using?  (run 'go version' or 'gccgo --version')

tip

Please provide any additional information below.

This change will make time.Times 4 bytes smaller on 64-bit platforms.
@rsc
Copy link
Contributor

rsc commented Mar 4, 2014

Comment 1:

No, it won't make it any smaller, due to alignment.

Labels changed: added release-go1.4.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Apr 1, 2014

Comment 2:

Issue #7664 has been merged into this issue.

@rsc
Copy link
Contributor

rsc commented Apr 1, 2014

Comment 3:

Probably okay, but not for Go 1.3.

@gopherbot
Copy link

Comment 4:

CL https://golang.org/cl/112870046 mentions this issue.

@rsc
Copy link
Contributor

rsc commented Jul 16, 2014

Comment 5:

This issue was closed by revision 26d0f75.

Status changed to Fixed.

@rsc rsc mentioned this issue Dec 8, 2014
Closed
@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@rsc @wheatman
time: change nsec back to int32
89ac8eb 
The garbage collector and stack scans are good enough now.

Fixes golang#7446.

LGTM=r
R=r, dvyukov
CC=golang-codereviews, mdempsky, mtj
https://golang.org/cl/112870046
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@rsc @wheatman
time: change nsec back to int32
5e2a2ff 
The garbage collector and stack scans are good enough now.

Fixes golang#7446.

LGTM=r
R=r, dvyukov
CC=golang-codereviews, mdempsky, mtj
https://golang.org/cl/112870046
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
3 participants
@rsc @alberts @gopherbot