net/rpc/jsonrpc: drop response on error #7442

gopherbot · 2014-03-03T04:35:37Z

by yac.cz0:

net/rpc/jsonrpc/server.go: response result contains empty object "{}" instead
of "null" when error occurs

see `hg export`-ed patch in attachment

Attachments:

gopherbot · 2014-03-03T21:00:51Z

Comment 1 by yac.cz0:

I'm sorry this is my first time with hg so I guess I accidentaly two commits into the
patch instead of only the one fixing server.go

rsc · 2014-03-03T22:04:39Z

Comment 2:

Please submit the patch as described at golang.org/doc/contribute.html. Thanks. (The
1-line diff itself looks fine.)

Labels changed: added release-go1.3.

Status changed to Accepted.

gopherbot · 2014-03-05T09:01:22Z

Comment 3 by yac.cz0:

https://golang.org/cl/71230045/

bradfitz · 2014-03-06T00:01:46Z

Comment 4:

This issue was updated by revision 31731b2.

LGTM=adg
R=adg
CC=golang-codereviews
https://golang.org/cl/69860056

bradfitz · 2014-03-08T00:59:18Z

Comment 5:

This issue was closed by revision 7718c62.

Status changed to Fixed.

gopherbot · 2014-04-09T01:58:53Z

Comment 6:

CL https://golang.org/cl/71230045 references this issue.

gopherbot added fixed labels Apr 9, 2014

rsc added this to the Go1.3 milestone Apr 14, 2015

rsc removed the release-go1.3 label Apr 14, 2015

golang locked and limited conversation to collaborators Jun 25, 2016

gopherbot added the FrozenDueToAge label Jun 25, 2016

This issue was closed.

Provide feedback