cmd/vet: setting composites flag false doesn't do anything #7422
Labels
Comments
|
Comment 1 by herbert@clypd.com: Language in the documentation suggests that I can disable the associated checks (i.e. composites) by passing in the associated flag, but in fact it does the opposite, where by passing in the flag, it enables that particular set of checks. I was able to find a workaround in the meantime, by just passing in the set of flags for the tests I want to run, but it does look kind of ugly. |
|
Owner changed to @robpike. Status changed to Thinking. |
|
This issue was closed by revision golang/tools@6bd3206. Status changed to Fixed. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by herbert@clypd.com:
Create the test files like this (shell) mkdir vet_bug cd vet_bug export GOPATH=`pwd` mkdir src cd src mkdir a cat <<EOF > a/a.go package a type Tuple []string EOF cat <<EOF > main.go package t import "a" var x = a.Tuple{"a", "b", "c"} EOF go build ./... go tool vet -composites=false ./... This creates a directory structure like this with GOPATH set vet_bug └── src ├── a │ └── a.go └── main.go What is the expected output? nothing What do you see instead? src/main.go:5: a.Tuple composite literal uses unkeyed fields Which operating system are you using? mac os x 10.9 Which version are you using? (run 'go version' or 'gccgo --version') go version go1.2 darwin/amd64The text was updated successfully, but these errors were encountered: