Comment 1:

Labels changed: added release-go1.3.

Comment 2:

This will start working once objdump and nm work.

Comment 3:

This is still broken. I suspect it is because of issue #7899.
Alex

Comment 4:

CL https://golang.org/cl/96960043 mentions this issue.

Comment 6:

This issue was updated by revision b211d06.

Fixes issue #7899
LGTM=bradfitz
R=golang-codereviews, rsc, bradfitz
CC=golang-codereviews
https://golang.org/cl/96960043

Comment 7:

Making progress here. This is now works:
C:\go\root\src\pkg\archive\zip>go test -c && zip.test.exe -test.v -test.run=none
-test.bench=.*  -test.cpuprofile test.prof && go tool pprof zip.test.exe test.prof
PASS
BenchmarkCompressedZipGarbage         50          51874336 ns/op           51838 B/op   
    148 allocs/op
BenchmarkZip64Test             5         409369760 ns/op
Welcome to pprof!  For help, type 'help'.
(pprof) top
Total: 477 samples
     141  29.6%  29.6%      195  40.9% compress/flate.(*compressor).deflate
     126  26.4%  56.0%      128  26.8% archive/zip.(*rleBuffer).ReadAt
      85  17.8%  73.8%       85  17.8% archive/zip.(*rleBuffer).Write
      50  10.5%  84.3%       50  10.5% compress/flate.(*compressor).findMatch
      47   9.9%  94.1%       47   9.9% hash/crc32.update
      14   2.9%  97.1%       14   2.9% runtime.memmove
       2   0.4%  97.5%        2   0.4% compress/flate.(*compressor).reset
       2   0.4%  97.9%        2   0.4% compress/flate.(*huffmanBitWriter).writeBits
       2   0.4%  98.3%        4   0.8% compress/flate.(*huffmanBitWriter).writeBlock
       2   0.4%  98.7%      130  27.3% io.(*SectionReader).Read
but source code displaying
       
(pprof) list findMatch
Total: 477 samples
ROUTINE ====================== compress/flate.(*compressor).findMatch in
c:/go/root/src/pkg/archive/zip/reader.go
    50     50 Total samples (flat / cumulative)---
    50     50    1: // Copyright 2010 The Go Authors. All rights reserved.---
     .      .    2: // Use of this source code is governed by a BSD-style
     .      .    3: // license that can be found in the LICENSE file.
     .      .    4:
     .      .    5: package zip
     .      .    6:
(pprof)
does not. objdump is still broken on windows. I think working objdump will fix pprof
"list" command.
Alex

Comment 8:

CL https://golang.org/cl/95090044 mentions this issue.

Comment 9:

This issue was updated by revision 20aa947.

Fixes issue #7937
LGTM=iant
R=golang-codereviews, iant, 0intro
CC=golang-codereviews
https://golang.org/cl/95090044

Comment 10:

Alex, does source code listing work now? It should.
That is, 'list findMatch' should work in the transcript above.
I expect 'disasm findMatch' to not work yet, but that's no different than pprof anywhere
else.
If 'list findMatch' is working, please mark this bug fixed.

Comment 11:

'list findMatch' works only after I change misc/pprof to use "go tool objdump ..."
instead of "objdump .. ". I was going to find out if 'list findMatch' ever worked before
on windows, and how. But perhaps it is not important. Would change to misc/pprof be
welcome instead?
Alex

Comment 12:

Yes, pprof should be using 'go tool objdump' on Windows now.

Comment 13:

mingw objdump also used in ParseTextSectionHeaderFromObjdump in misc/pprof. What about
that? "go tool objdump" does not implement such function.
Alex

Comment 14:

CL https://golang.org/cl/97440043 mentions this issue.

Comment 15:

This issue was closed by revision fcfc17f.

Status changed to Fixed.