Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: linkname directive on userspace variable can override runtime variable [1.24 backport] #73092

Open
gopherbot opened this issue Mar 28, 2025 · 2 comments
Open

cmd/link: linkname directive on userspace variable can override runtime variable [1.24 backport] #73092

gopherbot opened this issue Mar 28, 2025 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.24.3

Comments

@gopherbot
Copy link
Contributor

@cherrymui requested issue #72032 to be considered for backport to the next 1.24 minor release.

@gopherbot please backport this to previous releases. This is a regression that breaks some existing uses of linkname. Thanks.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 28, 2025
@gopherbot gopherbot mentioned this issue Mar 28, 2025
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 28, 2025
@gopherbot gopherbot modified the milestones: Go1.24.2, Go1.24.3 Mar 28, 2025
@cagedmantis
Copy link
Contributor

This backport request has been approved. We should keep compatibility with previous versions.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Apr 2, 2025
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 2, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/662335 mentions this issue: [release-branch.go1.24] cmd/link: choose one with larger size for duplicated BSS symbols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.24.3
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot