Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: provide TLS info in http.Response #7289

Closed
pquerna opened this issue Feb 8, 2014 · 4 comments
Closed

net/http: provide TLS info in http.Response #7289

pquerna opened this issue Feb 8, 2014 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.3

Comments

@pquerna
Copy link

pquerna commented Feb 8, 2014 

Simple use case: Log the client ciphers used to do a HTTPS request.

When acting as a HTTPS client, Responses returned by the RoundTripper do not have a way
to tell what connection was used to do the work. 

When acting as a server, http.Request.TLS is set to the tls.ConnectionState.  It seems
reasonable to add an optionally filled TLS member to the http.Response struct, and set
it when using a TLS Client Connection.
@pquerna
Copy link
Author

pquerna commented Feb 8, 2014

Comment 1:

Patch Available: https://golang.org/cl/52660047/

@rsc
Copy link
Contributor

rsc commented Mar 3, 2014

Comment 2:

Labels changed: added release-go1.3maybe.

Status changed to Accepted.

@bradfitz
Copy link
Contributor

bradfitz commented Mar 5, 2014

Comment 3:

This issue was closed by revision 4816986.

Status changed to Fixed.

@bradfitz
Copy link
Contributor

bradfitz commented Mar 5, 2014

Comment 4:

This issue was updated by revision 6433bff.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/71740043

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.3
Development

No branches or pull requests
4 participants
@bradfitz @rsc @pquerna @gopherbot