Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: assertion failed: cmd/compile/internal/noder/reader.go:765 #72873

Open
Kronos3 opened this issue Mar 14, 2025 · 2 comments
Open

cmd/compile: assertion failed: cmd/compile/internal/noder/reader.go:765 #72873

Kronos3 opened this issue Mar 14, 2025 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.

Comments

@Kronos3
Copy link

Kronos3 commented Mar 14, 2025 •
edited
Loading

Go version

1.24.1

Output of go env in your module/workspace:

AR='ar'
CC='cc'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='c++'
GCCGO='gccgo'
GO111MODULE=''
GOARCH='arm64'
GOARM64='v8.0'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/Users/tumbar/Library/Caches/go-build'
GOCACHEPROG=''
GODEBUG=''
GOENV='/Users/tumbar/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/8r/7cbk0vm570b95g0hjpt05v_h0000gq/T/go-build1208629441=/tmp/go-build -gno-record-gcc-switches -fno-common'
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMOD='/Users/tumbar/git/rsvp-lite/go.mod'
GOMODCACHE='/Users/tumbar/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/tumbar/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/opt/homebrew/opt/go/libexec'
GOSUMDB='sum.golang.org'
GOTELEMETRY='local'
GOTELEMETRYDIR='/Users/tumbar/Library/Application Support/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/opt/homebrew/opt/go/libexec/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.24.1'
GOWORK=''
PKG_CONFIG='pkg-config'

What did you do?

I exposed a function to an interface that my implementation struct already had implemented and it crashed the compiler.

What did you see happen?

I get a fatal error on both 1.24.1 and gotip:

[...] internal compiler error: assertion failed

goroutine 1 [running]:
runtime/debug.Stack()
        ../../sdk/gotip/src/runtime/debug/stack.go:26 +0x64
cmd/compile/internal/base.FatalfAt({0x14efa40?, 0x140?}, {0x1054c580d, 0x10}, {0x0, 0x0, 0x0})
        ../../sdk/gotip/src/cmd/compile/internal/base/print.go:230 +0x204
cmd/compile/internal/base.Fatalf(...)
        ../../sdk/gotip/src/cmd/compile/internal/base/print.go:195
cmd/compile/internal/base.Assert(...)
        ../../sdk/gotip/src/cmd/compile/internal/base/print.go:242
cmd/compile/internal/noder.assert(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/writer.go:63
cmd/compile/internal/noder.(*pkgReader).objIdxMayFail(0x140009348c0, 0x1a, {0x0, 0x0, 0x0}, {0x140012efa18, 0x1, 0x1}, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:765 +0xcec
cmd/compile/internal/noder.(*pkgReader).objIdx(0x140009348c0?, 0x14da550?, {0x0?, 0x2?, 0x140014e1520?}, {0x140012efa18?, 0x1a00000006?, 0x0?}, 0x1?)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:674 +0x24
cmd/compile/internal/noder.(*pkgReader).objInstIdx(0x140009348c0, {0x2cfdcd78?, {0x140014da550?, 0x105389854?, 0x12ce3f9fd?}}, 0x140014e1520, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:666 +0x88
cmd/compile/internal/noder.(*reader).obj(0x14000d4f730)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:636 +0x54
cmd/compile/internal/noder.(*reader).doTyp(0x14000d4f730)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:502 +0x78
cmd/compile/internal/noder.(*pkgReader).typIdx(0x140009348c0, {0x83, 0x0}, 0x140014e1520, 0x1)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:429 +0x148
cmd/compile/internal/noder.(*pkgReader).typListIdx(0x140009348c0, {0x140014da508, 0x1, 0x105439fe8?}, 0x140014e1520)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:404 +0x84
cmd/compile/internal/noder.(*pkgReader).objInstIdx(0x140009348c0, {0x5?, {0x140014da508?, 0x10543a060?, 0x140009348c0?}}, 0x140014e1520, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:659 +0x40
cmd/compile/internal/noder.(*reader).obj(0x140014eedc0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:636 +0x54
cmd/compile/internal/noder.(*reader).doTyp(0x140014eedc0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:502 +0x78
cmd/compile/internal/noder.(*pkgReader).typIdx(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:429
cmd/compile/internal/noder.(*reader).typWrapped(0x140014eec80, 0x1)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:388 +0xd4
cmd/compile/internal/noder.(*reader).typ(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:382
cmd/compile/internal/noder.(*reader).doTyp(0x140014eec80)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:516 +0x36c
cmd/compile/internal/noder.(*pkgReader).typIdx(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:429
cmd/compile/internal/noder.(*reader).typWrapped(0x140014ee3c0, 0x1)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:388 +0xd4
cmd/compile/internal/noder.(*reader).typ(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:382
cmd/compile/internal/noder.(*reader).structType(0x140014ee3c0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:591 +0x88
cmd/compile/internal/noder.(*reader).doTyp(0x140014ee3c0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:524 +0x3a4
cmd/compile/internal/noder.(*pkgReader).typIdx(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:429
cmd/compile/internal/noder.(*reader).typWrapped(0x140014ee000, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:388 +0xd4
cmd/compile/internal/noder.(*pkgReader).objIdxMayFail(0x140009348c0, 0x143, {0x0, 0x0, 0x0}, {0x105dade00, 0x0, 0x0}, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:832 +0x5d8
cmd/compile/internal/noder.(*pkgReader).objIdx(0x140009348c0?, 0x5dade00?, {0x0?, 0x105439fe8?, 0x140014e1450?}, {0x105dade00?, 0x143014ebb80?, 0x10543a490?}, 0x0?)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:674 +0x24
cmd/compile/internal/noder.(*pkgReader).objInstIdx(0x140009348c0, {0x5?, {0x105dade00?, 0x10543a060?, 0x140009348c0?}}, 0x140014e1450, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:666 +0x88
cmd/compile/internal/noder.(*reader).obj(0x140014ebb80)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:636 +0x54
cmd/compile/internal/noder.(*reader).doTyp(0x140014ebb80)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:502 +0x78
cmd/compile/internal/noder.(*pkgReader).typIdx(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:429
cmd/compile/internal/noder.(*reader).typWrapped(0x140014eba40, 0x1)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:388 +0xd4
cmd/compile/internal/noder.(*reader).typ(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:382
cmd/compile/internal/noder.(*reader).doTyp(0x140014eba40)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:518 +0xf4
cmd/compile/internal/noder.(*pkgReader).typIdx(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:429
cmd/compile/internal/noder.(*reader).typWrapped(0x140014eb900, 0x1)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:388 +0xd4
cmd/compile/internal/noder.(*reader).typ(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:382
cmd/compile/internal/noder.(*reader).param(0x140014eb900)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:624 +0x78
cmd/compile/internal/noder.(*reader).params(0x140014eb900)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:617 +0x78
cmd/compile/internal/noder.(*reader).signature(0x140014eb900, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:604 +0x38
cmd/compile/internal/noder.(*reader).doTyp(0x140014eb900)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:520 +0x390
cmd/compile/internal/noder.(*pkgReader).typIdx(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:429
cmd/compile/internal/noder.(*reader).typWrapped(0x140014eb540, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:388 +0xd4
cmd/compile/internal/noder.(*pkgReader).objIdxMayFail(0x140009348c0, 0x142, {0x0, 0x0, 0x0}, {0x105dade00, 0x0, 0x0}, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:832 +0x5d8
cmd/compile/internal/noder.(*pkgReader).objIdxMayFail(0x14000935420, 0x64, {0x0, 0x0, 0x0}, {0x105dade00, 0x0, 0x0}, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:699 +0x360
cmd/compile/internal/noder.(*pkgReader).objIdx(0x14000935420?, 0x5dade00?, {0x0?, 0x105439fe8?, 0x140014e1380?}, {0x105dade00?, 0x64014eaf00?, 0x10543a490?}, 0x0?)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:674 +0x24
cmd/compile/internal/noder.(*pkgReader).objInstIdx(0x14000935420, {0x5?, {0x105dade00?, 0x10543a060?, 0x14000935420?}}, 0x140014e1380, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:666 +0x88
cmd/compile/internal/noder.(*reader).obj(0x140014eaf00)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:636 +0x54
cmd/compile/internal/noder.(*reader).doTyp(0x140014eaf00)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:502 +0x78
cmd/compile/internal/noder.(*pkgReader).typIdx(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:429
cmd/compile/internal/noder.(*reader).typWrapped(0x140014eadc0, 0x1)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:388 +0xd4
cmd/compile/internal/noder.(*reader).typ(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:382
cmd/compile/internal/noder.(*reader).doTyp(0x140014eadc0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:522 +0x2d4
cmd/compile/internal/noder.(*pkgReader).typIdx(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:429
cmd/compile/internal/noder.(*reader).typWrapped(0x140014eaa00, 0x1)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:388 +0xd4
cmd/compile/internal/noder.(*reader).typ(...)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:382
cmd/compile/internal/noder.(*reader).param(0x140014eaa00)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:624 +0x78
cmd/compile/internal/noder.(*reader).params(0x140014eaa00)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:617 +0x78
cmd/compile/internal/noder.(*reader).signature(0x140014eaa00, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:604 +0x38
cmd/compile/internal/noder.(*pkgReader).objIdxMayFail(0x14000935420, 0x65, {0x0, 0x0, 0x0}, {0x105dade00, 0x0, 0x0}, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:791 +0x800
cmd/compile/internal/noder.(*pkgReader).objIdx(0x14000935420?, 0x5dade00?, {0x0?, 0x10600d8a0?, 0x0?}, {0x105dade00?, 0x6500d512f8?, 0x10544b13c?}, 0x0?)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:674 +0x24
cmd/compile/internal/noder.(*pkgReader).objInstIdx(0x14000935420, {0x543ea7c?, {0x105dade00?, 0x10544b650?, 0x8?}}, 0x0, 0x0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:666 +0x88
cmd/compile/internal/noder.(*reader).obj(0x14000a092c0)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:636 +0x54
cmd/compile/internal/noder.(*reader).pkgObjs(0x14000a092c0, 0x140000c4240)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:3373 +0x84
cmd/compile/internal/noder.(*reader).pkgDecls(0x14000a092c0, 0x140000c4240)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:3337 +0x58
cmd/compile/internal/noder.(*reader).pkgInit(0x14000a092c0, 0x140000c62d0?, 0x140000c4240)
        ../../sdk/gotip/src/cmd/compile/internal/noder/reader.go:3268 +0xd8
cmd/compile/internal/noder.unified({0x0?, {0x0?, 0x0?}}, {0x140004226c0?, 0x10566f180?, 0x0?})
        ../../sdk/gotip/src/cmd/compile/internal/noder/unified.go:203 +0x170
cmd/compile/internal/noder.LoadPackage({0x140000037f0, 0x8, 0x9})
        ../../sdk/gotip/src/cmd/compile/internal/noder/noder.go:77 +0x36c
cmd/compile/internal/gc.Main(0x105739e50)
        ../../sdk/gotip/src/cmd/compile/internal/gc/main.go:208 +0xba0
main.main()
        ../../sdk/gotip/src/cmd/compile/main.go:57 +0x100

What did you expect to see?

I've been trying to reproduce a minimal example since I can't publish my code but I can't seem to get it crashing. I am fairly certain it has to do with interplay between separate packages since I've tried pulling out the relevant code into a single package and building that and it seems to work fine. When I build my main program I get an error like:

# another_package
crashing/package/file.go:60:6: internal compiler error: assertion failed

I think it might have to do with the order in which type aliases are resolved across package boundaries, see the assertion that this corresponds to:

go/src/cmd/compile/internal/noder/reader.go

Lines 753 to 773 in 7e3d2aa

// Clumsy dance: the r.typ() call here might recursively find this
// type alias name, before we've set its type (#66873). So we
// temporarily clear sym.Def and then restore it later, if still
// unset.
hack := sym.Def == name
if hack {
sym.Def = nil
}
typ := r.typ()
if hack {
if sym.Def != nil {
name = sym.Def.(*ir.Name)
assert(name.Type() == typ)
return name, nil
}
sym.Def = name
}
setType(name, typ)
name.SetAlias(true)
return name, nil

It would be helpful if someone more knowledgeable could take a look and give me some hints on what I might try to get a minimal example.
@Kronos3 Kronos3 changed the title compiler/internal: internal compiler error: assertion failed cmd/compiler: assertion failed: cmd/compile/internal/noder/reader.go:765 Mar 14, 2025
@randall77
Copy link
Contributor

It might be helpful if you could bisect the failure to find out what Go CL triggered the problem. Did your code compile correctly in 1.23?

@seankhliao seankhliao changed the title cmd/compiler: assertion failed: cmd/compile/internal/noder/reader.go:765 cmd/compile: assertion failed: cmd/compile/internal/noder/reader.go:765 Mar 14, 2025
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 14, 2025
@seankhliao seankhliao added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. compiler/runtime Issues related to the Go compiler and/or runtime. and removed compiler/runtime Issues related to the Go compiler and/or runtime. labels Mar 14, 2025
@Kronos3
Copy link
Author

Kronos3 commented Mar 14, 2025

I can't compile it with default 1.23 since it has generic type aliases, which actually seems to be the source of the problem. I removed the generic type alias from my code and it builds.

I also tried enabling GOEXPERIMENT=aliastypeparams and it has the same error as in 1.24.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
Go Compiler / Runtime
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@randall77 @gopherbot @seankhliao @Kronos3