Skip to content

cmd/compile: OOM with mutually-recursive iter.Seq [1.24 backport] #72822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 12, 2025 · 2 comments
Closed

cmd/compile: OOM with mutually-recursive iter.Seq [1.24 backport] #72822

gopherbot opened this issue Mar 12, 2025 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.24.2

Comments

@gopherbot
Copy link
Contributor

@dr2chase requested issue #72090 to be considered for backport to the next 1.24 minor release.

@gopherbot please consider this for backport to 1.24, it’s a regression.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 12, 2025
@gopherbot gopherbot mentioned this issue Mar 12, 2025
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 12, 2025
@gopherbot gopherbot added this to the Go1.24.2 milestone Mar 12, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/657075 mentions this issue: [release-branch.go1.24] cmd/compile: use inline-Pos-based recursion test

@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Mar 12, 2025
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 12, 2025
gopherbot pushed a commit that referenced this issue Mar 12, 2025
@dr2chase
[release-branch.go1.24] cmd/compile: use inline-Pos-based recursion test
c2a34be 
Look at the inlining stack of positions for a call site,
if the line/col/file of the call site appears in that
stack, do not inline.  This subsumes all the other
recently-added recursive inlining checks, but they are
left in to make this easier+safer to backport.

Fixes #72822

Change-Id: I0f487bb0d4c514015907c649312672b7be464abd
Reviewed-on: https://go-review.googlesource.com/c/go/+/655155
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
(cherry picked from commit cad4dca)
Reviewed-on: https://go-review.googlesource.com/c/go/+/657075
@gopherbot
Copy link
Contributor Author

Closed by merging CL 657075 (commit c2a34be) to release-branch.go1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.24.2
Development

No branches or pull requests
2 participants
@dr2chase @gopherbot