Skip to content

cmd/compile, cmd/asm, x/sys/unix.test: unrecognized failures #72810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 12, 2025 · 8 comments
Closed

cmd/compile, cmd/asm, x/sys/unix.test: unrecognized failures #72810

gopherbot opened this issue Mar 12, 2025 · 8 comments
Assignees
@thanm
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted.
Milestone
Go1.25

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/sys/unix.test" && test == ""

Issue created automatically to collect these failures.

Example (log):

# golang.org/x/sys/unix.test
link: internal error: R_DWTXTADDR_U1 relocation overflow on infosym for libc_setpriority_trampoline

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 12, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/sys/unix.test" && test == ""
2025-03-05 15:56 x_sys-gotip-linux-amd64-misccompile sys@f2ce62c2 go@43648931 x/sys/unix.test (log) 
# golang.org/x/sys/unix.test
link: internal error: R_DWTXTADDR_U1 relocation overflow on infosym for libc_setpriority_trampoline

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Mar 12, 2025
@ianlancetaylor
Copy link
Member

CC @thanm Could this be related to the DWARF changes?

@thanm thanm self-assigned this Mar 12, 2025
@thanm
Copy link
Contributor

thanm commented Mar 12, 2025

CC @thanm Could this be related to the DWARF changes?

Yup, " R_DWTXTADDR_U1 relocation overflow" is definitely DWARF 5 related, thanks. I will take a look.

@thanm
Copy link
Contributor

thanm commented Mar 12, 2025

Hmm, I am having trouble producing this. The command from the LUCI log is

 [I2025-03-12T01:24:12.094120Z 368 0 cmd_stream.go:492] rdb-stream: starting the test command - ["/home/swarming/.swarming/w/ir/cache/tools/bin/result_adapter" "go" "-v=false" "--" "/home/swarming/.swarming/w/ir/x/w/goroot/bin/go" "test" "-json" "-c" "-o" "/dev/null" "./..."]

however when I try something similar on my linux/amd box it works fine, e.g.

$ cd golang.org/x/sys/unix
$ GHOSTOOS=linux GOHOSTARCH=amd64 GOOS=darwin GOARCH=amd64 go test -x -c -count=1 -v  -o t.exe  -vet=off
$ file t.exe
t.exe: Mach-O 64-bit x86_64 executable, flags:<|DYLDLINK|PIE>
$

What am I missing? I am stumped.

@thanm
Copy link
Contributor

thanm commented Mar 13, 2025

Still not having any luck reproducing this. I'll wait and see if it happens again...

@johejo
Copy link

johejo commented Mar 28, 2025

It seems this can be reproduced by building https://github.com/klauspost/reedsolomon/tree/master/examples with tip.

go version

go version devel go1.25-b17a99d6fc Thu Mar 27 15:39:38 2025 -0700 linux/amd64
go env 
AR='ar'
CC='gcc'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='g++'
GCCGO='gccgo'
GO111MODULE=''
GOAMD64='v1'
GOARCH='amd64'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/home/mitsuoheijo/.cache/go-build'
GOCACHEPROG=''
GODEBUG=''
GOENV='/home/mitsuoheijo/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build669280823=/tmp/go-build -gno-record-gcc-switches'
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMOD='/home/mitsuoheijo/repos/github.com/klauspost/reedsolomon/go.mod'
GOMODCACHE='/home/mitsuoheijo/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/mitsuoheijo/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/home/mitsuoheijo/repos/github.com/golang/go'
GOSUMDB='sum.golang.org'
GOTELEMETRY='local'
GOTELEMETRYDIR='/home/mitsuoheijo/.config/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/mitsuoheijo/repos/github.com/golang/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='devel go1.25-b17a99d6fc Thu Mar 27 15:39:38 2025 -0700'
GOWORK=''
PKG_CONFIG='pkg-config'

$ go build ./simple-encoder.go
# command-line-arguments
link: internal error: R_DWTXTADDR_U1 relocation overflow on infosym for github.com/klauspost/reedsolomon.mulAvxTwo_3x1_64Xor

@thanm
Copy link
Contributor

thanm commented Mar 31, 2025

It seems this can be reproduced by building https://github.com/klauspost/reedsolomon/tree/master/examples with tip.

Thanks. I will try to take a look later this week.

@thanm thanm mentioned this issue Apr 5, 2025
Closed
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/663235 mentions this issue: cmd: fix DWARF gen bug with packages that use assembly

@dmitshur dmitshur moved this to Active in Test Flakes Apr 6, 2025
@dmitshur dmitshur added FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 6, 2025
@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Apr 13, 2025
@dmitshur dmitshur changed the title x/sys/unix.test: unrecognized failures cmd/compile, cmd/asm, x/sys/unix.test: unrecognized failures Apr 14, 2025
@dmitshur dmitshur modified the milestones: Unreleased, Go1.25 Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanm thanm

Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted.
Projects
Test Flakes
Status: Done
Milestone
Go1.25
Development

No branches or pull requests
5 participants
@dmitshur @ianlancetaylor @gopherbot @thanm @johejo